Add chart, p0.raw, p1.raw to segment context #9761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etimberg
previously approved these changes
Oct 13, 2021
etimberg
previously approved these changes
Oct 13, 2021
|
There's a conflict that needs a rebase here. Hopefully that also fixes the CI |
etimberg
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9692
Additionally move context creation to a helper function to remove duplication.
The
parsedis removed from points when there are no segments, this could be considered breaking. Its not documented or advertised in other contexts though. It was introduces by #8844 and has been available since v3.1 (~6 months)Another notable thing is the
nullprototype for chart context. It was that way in beta, but was removed by #8413 (v3.0).