Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix object notation border width barchart #9800

Merged
merged 3 commits into from Oct 26, 2021
Merged

Fix object notation border width barchart #9800

merged 3 commits into from Oct 26, 2021

Conversation

LeeLenaleee
Copy link
Collaborator

resolves #9799

@LeeLenaleee LeeLenaleee added the type: types Typescript type changes label Oct 26, 2021
@LeeLenaleee LeeLenaleee added this to the Version 3.6.1 milestone Oct 26, 2021
@kurkle
Copy link
Member

kurkle commented Oct 26, 2021

Does it not work the other way around, leaving the common as is overriding for bar?

@LeeLenaleee
Copy link
Collaborator Author

LeeLenaleee commented Oct 26, 2021 •
edited

No then I get an error that the BarOptions incorrectly extends the CommonElementOptions interface since the borderWidth is incompatible.

EDIT:
Yes it is possible by ommiting the borderWidth prop from the interface while extending it

@etimberg etimberg merged commit 10106e4 into chartjs:master Oct 26, 2021
@LeeLenaleee LeeLenaleee deleted the types/bar-borderradius branch October 26, 2021 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

@kurkle kurkle kurkle approved these changes

Assignees
No one assigned
Labels
type: types Typescript type changes
Projects
None yet
Milestone
Version 3.6.1
Development

Successfully merging this pull request may close these issues.

Invalid 'borderWidth' typescript definition
3 participants
@LeeLenaleee @kurkle @etimberg