Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define with let to avoid "assignment to constant" errors #9803

Merged
merged 3 commits into from Oct 30, 2021

Conversation

erictheise
Copy link
Contributor

Thanks for this example. Defining label with const rather than let results in Uncaught TypeError: Assignment to constant variable.

Thanks for this example. Defining `label` with `const` rather than `let` results in `Uncaught TypeError: Assignment to constant variable.`
LeeLenaleee
LeeLenaleee previously approved these changes Oct 27, 2021
etimberg
etimberg previously approved these changes Oct 27, 2021
@LeeLenaleee
Copy link
Collaborator

LeeLenaleee commented Oct 27, 2021

Gave the other example (external tooltip) also a look and there is the same issue so if you could change it there too.

tooltipEl, innerHtml and tableRoot seem to be overriden while being const's

@erictheise
Copy link
Contributor Author

Be happy to take care of that later today @LeeLenaleee.

@erictheise erictheise dismissed stale reviews from etimberg and LeeLenaleee via 1b9732b October 28, 2021 05:49
@etimberg etimberg merged commit 67c5a85 into chartjs:master Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants