Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update animation event to include currentStep instead of currentState #9837

Merged
merged 1 commit into from Nov 11, 2021
Merged

update animation event to include currentStep instead of currentState #9837

merged 1 commit into from Nov 11, 2021

Conversation

NorthBlue333
Copy link
Contributor

resolves #9833 (second part)

@LeeLenaleee
Copy link
Collaborator

MB, read over that, thanks for pointing it out and fixing it

@LeeLenaleee LeeLenaleee added the type: types Typescript type changes label Nov 11, 2021
@LeeLenaleee LeeLenaleee added this to the Version 3.6.1 milestone Nov 11, 2021
@kurkle kurkle merged commit 7da77a5 into chartjs:master Nov 11, 2021
@NorthBlue333 NorthBlue333 deleted the types/animationEvent branch November 11, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

@kurkle kurkle kurkle approved these changes

@LeeLenaleee LeeLenaleee LeeLenaleee approved these changes

@StevenD33 StevenD33 StevenD33 approved these changes

Assignees
No one assigned
Labels
type: types Typescript type changes
Projects
None yet
Milestone
Version 3.6.1
Development

Successfully merging this pull request may close these issues.

AnimationEvent is incorrectly typed
5 participants
@NorthBlue333 @LeeLenaleee @etimberg @kurkle @StevenD33