Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect detach/attach in same observation #9876

Merged
merged 3 commits into from Nov 27, 2021
Merged

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Nov 19, 2021

Fixes: #9875

etimberg
etimberg previously approved these changes Nov 20, 2021
src/platform/platform.dom.js Outdated Show resolved Hide resolved
@kurkle kurkle marked this pull request as ready for review November 20, 2021 09:00
@kurkle
Copy link
Member Author

kurkle commented Nov 21, 2021

Filename Size Change
dist/chart.esm.js 73.1 kB +58 B (0%)
dist/chart.js 92.5 kB +61 B (0%)
dist/chart.min.js 65.7 kB +37 B (0%)

@etimberg
Copy link
Member

@kurkle are you ok if I merge this?

@kurkle kurkle merged commit bccb127 into chartjs:master Nov 27, 2021
@LovelyAndy
Copy link
Contributor

Quick question: In which version will this be released on NPM?
Thanks for the help guys!

@kurkle kurkle deleted the detach-attach branch November 28, 2021 04:10
@kurkle
Copy link
Member Author

kurkle commented Nov 28, 2021

This will be in version 3.6.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chart disappears (height and width set to 0) when responsive is true and chart is dragged
3 participants