Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Category: Track automatically added labels #9921

Merged
merged 2 commits into from Nov 29, 2021
Merged

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Nov 29, 2021

Fixes: #9599
Closes: #9601

Automatically added labels were never cleaned up. This adds tracking of the labels that are added and removes those at the start of every update cycle.

scale.init is called every update by buildOrUpdateScales here:

scale.init(scaleOptions, options);

@kurkle kurkle added this to the Version 3.6.1 milestone Nov 29, 2021
@kurkle
Copy link
Member Author

kurkle commented Nov 29, 2021

Filename Size Change
dist/chart.esm.js 73.2 kB +122 B (0%)
dist/chart.js 92.6 kB +120 B (0%)
dist/chart.min.js 65.8 kB +73 B (0%)

@kurkle kurkle merged commit 9345250 into chartjs:master Nov 29, 2021
@kurkle kurkle deleted the labels-issues branch November 29, 2021 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: chart labels are not updated properly if parsing object data
2 participants