Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass object from array as value to _fallback #9969

Merged
merged 4 commits into from Dec 8, 2021

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Dec 7, 2021

Encountered this edge case when doing things with chartjs-plugin-annotation.

When there was an object with the same name as the array of objects that we are trying to resolve, the _fallback functions value was actually the last object value with that name, not the array entry as expected.

This is a problem in annotation plugin where the annotation type is read from the value passed to _fallback to determine what defaults should be used.

@kurkle kurkle added this to the Version 3.7.0 milestone Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants