Pass object from array as value to _fallback #9969
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encountered this edge case when doing things with
chartjs-plugin-annotation
.When there was an object with the same name as the array of objects that we are trying to resolve, the
_fallback
functionsvalue
was actually the last object value with that name, not the array entry as expected.This is a problem in annotation plugin where the annotation
type
is read from thevalue
passed to_fallback
to determine what defaults should be used.