Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types/Allow min-max as string timescale #9985

Merged
merged 3 commits into from Dec 14, 2021

Conversation

LeeLenaleee
Copy link
Collaborator

Resolves #9984

@LeeLenaleee LeeLenaleee added the type: types Typescript type changes label Dec 14, 2021
@LeeLenaleee LeeLenaleee added this to the Version 3.7.0 milestone Dec 14, 2021
@LeeLenaleee
Copy link
Collaborator Author

Seems like docs need update too

@LeeLenaleee
Copy link
Collaborator Author

The min and max property are now documented twice, this is the same as in the docs page for the category scale where they can be strings too.

Not sure what would be better, removing the common to all options section and manually adding those props to both pages which will add maintanance overhead if a new property is added. But it will remove the double declaration of min and max from which one is typed wrong.

Or we can just ignore it since it still describes the property as available and in the top it shows as able to be a string but this might add confusion to any readers why we specify it twice as different types

docs/axes/cartesian/time.md Outdated Show resolved Hide resolved
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to solve the double declaration, but it should not block this fix.

@etimberg etimberg merged commit 0a5c058 into chartjs:master Dec 14, 2021
@LeeLenaleee LeeLenaleee deleted the types/min-max branch December 14, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: types Typescript type changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typings incorrect for Axis Range min and max settings
3 participants