Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Types/ type suggestedMin and suggestedMax for time scale #9986

Merged
merged 2 commits into from Dec 14, 2021
Merged

Types/ type suggestedMin and suggestedMax for time scale #9986

merged 2 commits into from Dec 14, 2021

Conversation

LeeLenaleee
Copy link
Collaborator

Followup on #9985.

Noticed the suggestedMin and suggestedMax props where also missing for the timescale

@LeeLenaleee LeeLenaleee added the type: types Typescript type changes label Dec 14, 2021
@LeeLenaleee LeeLenaleee added this to the Version 3.7.0 milestone Dec 14, 2021
etimberg
etimberg previously approved these changes Dec 14, 2021
View reviewed changes
kurkle
kurkle reviewed Dec 14, 2021
View reviewed changes
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these actually be number|string as the number could be considered preferred/compatible to all other scales and it would be in alphabetical order.

@etimberg etimberg merged commit 30bebef into chartjs:master Dec 14, 2021
@LeeLenaleee LeeLenaleee deleted the types/suggestedmin-max branch December 14, 2021 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

@kurkle kurkle kurkle approved these changes

Assignees
No one assigned
Labels
type: types Typescript type changes
Projects
None yet
Milestone
Version 3.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LeeLenaleee @etimberg @kurkle