From 8ae16090ce03bc3937ac25add57e67dc5cf06143 Mon Sep 17 00:00:00 2001 From: Evert Timberg Date: Sat, 5 Feb 2022 09:11:41 -0500 Subject: [PATCH 1/2] Correct type for updateHoverStyle --- types/index.esm.d.ts | 2 +- types/tests/interaction.ts | 17 +++++++++++++++++ 2 files changed, 18 insertions(+), 1 deletion(-) create mode 100644 types/tests/interaction.ts diff --git a/types/index.esm.d.ts b/types/index.esm.d.ts index 241de62a110..392849a0b4a 100644 --- a/types/index.esm.d.ts +++ b/types/index.esm.d.ts @@ -528,7 +528,7 @@ export declare class Chart< toBase64Image(type?: string, quality?: unknown): string; bindEvents(): void; unbindEvents(): void; - updateHoverStyle(items: Element, mode: 'dataset', enabled: boolean): void; + updateHoverStyle(items: InteractionItem[], mode: 'dataset', enabled: boolean): void; notifyPlugins(hook: string, args?: AnyObject): boolean | void; diff --git a/types/tests/interaction.ts b/types/tests/interaction.ts new file mode 100644 index 00000000000..ba3be2d947a --- /dev/null +++ b/types/tests/interaction.ts @@ -0,0 +1,17 @@ +import { + Chart, ChartData, ChartConfiguration, Element + } from '../index.esm'; + + const data: ChartData<'line'> = {datasets: []}; + const chartItem = 'item'; + const config: ChartConfiguration<'line'> = {type: 'line', data}; + const chart : Chart = new Chart(chartItem, config); + + type Item = { + element: Element, + datasetIndex: number, + index: number + } + + const elements : Item[] = []; + chart.updateHoverStyle(elements, 'dataset', true); \ No newline at end of file From b10d190f05d0ca47fcb11fad4cb6791b0f23ff3e Mon Sep 17 00:00:00 2001 From: Evert Timberg Date: Sat, 5 Feb 2022 09:23:26 -0500 Subject: [PATCH 2/2] Lint fixes --- types/tests/interaction.ts | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/types/tests/interaction.ts b/types/tests/interaction.ts index ba3be2d947a..e5df1da1995 100644 --- a/types/tests/interaction.ts +++ b/types/tests/interaction.ts @@ -1,17 +1,17 @@ import { - Chart, ChartData, ChartConfiguration, Element - } from '../index.esm'; - - const data: ChartData<'line'> = {datasets: []}; - const chartItem = 'item'; - const config: ChartConfiguration<'line'> = {type: 'line', data}; - const chart : Chart = new Chart(chartItem, config); - - type Item = { - element: Element, - datasetIndex: number, - index: number - } - - const elements : Item[] = []; - chart.updateHoverStyle(elements, 'dataset', true); \ No newline at end of file + Chart, ChartData, ChartConfiguration, Element +} from '../index.esm'; + +const data: ChartData<'line'> = { datasets: [] }; +const chartItem = 'item'; +const config: ChartConfiguration<'line'> = { type: 'line', data }; +const chart: Chart = new Chart(chartItem, config); + +type Item = { + element: Element, + datasetIndex: number, + index: number +} + +const elements: Item[] = []; +chart.updateHoverStyle(elements, 'dataset', true);