Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid deprecation warnings in tests #6246

Merged
merged 1 commit into from May 6, 2019
Merged

Avoid deprecation warnings in tests #6246

merged 1 commit into from May 6, 2019

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented May 5, 2019 •
edited

  • Move time.min/max to ticks
  • Remove time.format from defaults & test
  • Supply parser when using incomplete date strings

benmccann
benmccann previously approved these changes May 5, 2019
View reviewed changes
simonbrunel
simonbrunel requested changes May 5, 2019
View reviewed changes
Copy link
Member

@simonbrunel simonbrunel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think indentation of json files needs to be fixed first.

@kurkle kurkle force-pushed the chore-clean-test-warnings branch from 4089c38 to 93c4b70 Compare May 5, 2019 15:34
@kurkle
Copy link
Member Author

kurkle commented May 5, 2019

Indentation fixed.

@simonbrunel simonbrunel added this to the Version 2.9 milestone May 5, 2019
@simonbrunel simonbrunel merged commit 58e154c into chartjs:master May 6, 2019
@snyk-bot snyk-bot mentioned this pull request Nov 9, 2019
Merged
@kurkle kurkle deleted the chore-clean-test-warnings branch November 13, 2019 06:15
This was referenced Mar 4, 2020
Open
Open
@vpetersson vpetersson mentioned this pull request Mar 7, 2020
Merged
This was referenced Mar 9, 2020
Closed
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
This was referenced Apr 14, 2020
Open
Open
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
@kurkle @simonbrunel
Avoid time related deprecation warnings in tests (chartjs#6246)
0d81fd3
This was referenced Jun 1, 2021
Closed
Merged
Closed
Open
Closed
Open
Open
This was referenced Jul 5, 2021
Closed
Open
This was referenced Jul 27, 2021
Closed
Merged
Merged
This was referenced Oct 14, 2021
Merged
Closed
@jw jw mentioned this pull request Jan 17, 2022
Open
1 task
This was referenced Jan 21, 2022
Merged
Closed
This was referenced Feb 4, 2022
Closed
Closed
This was referenced Mar 7, 2022
Open
Open
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request Jul 6, 2022
Closed
1 task
@mend-for-github-com mend-for-github-com bot mentioned this pull request Aug 13, 2022
Merged
1 task
This was referenced Nov 29, 2022
Open
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request Jan 26, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmccann benmccann benmccann approved these changes

@nagix nagix nagix approved these changes

@simonbrunel simonbrunel simonbrunel approved these changes

Assignees
No one assigned
Labels
type: chore
Projects
None yet
Milestone
Version 2.9
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kurkle @benmccann @nagix @simonbrunel