Use tick.major rather than recomputing #6265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurkle
previously requested changes
May 11, 2019
simonbrunel
requested changes
May 11, 2019
src/scales/scale.time.js
Outdated
| @@ -408,8 +408,9 @@ function computeOffsets(table, ticks, min, max, options) { | |||
| return {start: start, end: end}; | |||
| } | |||
|
|
|||
| function ticksFromTimestamps(scale, values, majorUnit) { | |||
| function ticksFromTimestamps(scale, values) { | |||
There was a problem hiding this comment.
I'm not fan of this change because it makes the code harder to maintain by obfuscating the method inputs. Except for _adapter, I wouldn't assume any of the other scale computed values to be available at the time of calling this method.
There was a problem hiding this comment.
Not sure if we care about the size, but the way I wrote it is 6 bytes smaller
|
Thanks for the review @simonbrunel. I've updated the PR |
etimberg
previously approved these changes
May 12, 2019
kurkle
previously approved these changes
May 12, 2019
simonbrunel
previously approved these changes
May 13, 2019
|
@benmccann Can you rebase this PR? |
benmccann
dismissed stale reviews from simonbrunel, kurkle, and etimberg
via
fd9aa32
benmccann
force-pushed
the
major-compute-once
branch
from
729aa1e
to
fd9aa32
Compare
|
Thanks. I've rebased this PR |
simonbrunel
approved these changes
May 13, 2019
kurkle
approved these changes
May 13, 2019
etimberg
approved these changes
May 13, 2019
This was referenced Mar 4, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
This was referenced Jun 1, 2021
This was referenced Jul 5, 2021
This was referenced Jul 27, 2021
This was referenced Oct 14, 2021
1 task
This was referenced Jan 21, 2022
This was referenced Feb 4, 2022
This was referenced Mar 7, 2022
Closed
1 task
1 task
This was referenced Nov 29, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getLabelForIndexis ignoring the value oftick.majorand recomputing it, which means you can't use your own computation oftick.majorinafterBuildTicks