Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat null as NaN in radialLinear scale #6282

Merged
merged 2 commits into from May 21, 2019
Merged

Treat null as NaN in radialLinear scale #6282

merged 2 commits into from May 21, 2019

Conversation

nagix
Copy link
Contributor

@nagix nagix commented May 17, 2019

Currently null value is treated as the minimum value on a radialLinear scale. To be consistent with other scales, null should be treated as NaN.

Master: https://jsfiddle.net/nagix/vskjcz41/
Screen Shot 2019-05-17 at 1 12 55 AM

This PR: https://jsfiddle.net/nagix/g6x7Lt91/
Screen Shot 2019-05-17 at 1 13 18 AM

@nagix nagix mentioned this pull request May 17, 2019
Merged
kurkle
kurkle previously approved these changes May 17, 2019
View reviewed changes
@nagix
Copy link
Contributor Author

nagix commented May 17, 2019

I realized it's ok to directly return NaN.

etimberg
etimberg previously approved these changes May 17, 2019
View reviewed changes
kurkle
kurkle previously approved these changes May 17, 2019
View reviewed changes
benmccann
benmccann previously approved these changes May 18, 2019
View reviewed changes
@simonbrunel simonbrunel added this to the Version 2.9 milestone May 21, 2019
@simonbrunel
Copy link
Member

@nagix tests of this PR need to be updated after the merge of #6281

@nagix nagix dismissed stale reviews from benmccann, kurkle, and etimberg via 4928dcf May 21, 2019 09:32
@nagix
Copy link
Contributor Author

nagix commented May 21, 2019

Rebased and updated image tests based on #6281.

@simonbrunel simonbrunel merged commit 03a3199 into chartjs:master May 21, 2019
@nagix nagix deleted the issue-6282 branch May 21, 2019 09:50
@simonbrunel
Copy link
Member

Thanks @nagix

@nagix nagix mentioned this pull request May 21, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Nov 9, 2019
Merged
This was referenced Mar 4, 2020
Open
Open
@vpetersson vpetersson mentioned this pull request Mar 7, 2020
Merged
This was referenced Mar 9, 2020
Closed
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 14, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 15, 2020
Open
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
@nagix @simonbrunel
Treat null as NaN in radialLinear scale (chartjs#6282)
5cbf424
This was referenced Jun 1, 2021
Closed
Merged
Closed
Open
Closed
Open
Open
This was referenced Jul 5, 2021
Closed
Open
This was referenced Jul 27, 2021
Closed
Merged
Merged
This was referenced Oct 14, 2021
Merged
Closed
@jw jw mentioned this pull request Jan 17, 2022
Open
1 task
This was referenced Jan 21, 2022
Merged
Closed
This was referenced Feb 4, 2022
Closed
Closed
This was referenced Mar 7, 2022
Open
Open
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request Jul 6, 2022
Closed
1 task
@mend-for-github-com mend-for-github-com bot mentioned this pull request Aug 13, 2022
Merged
1 task
This was referenced Nov 29, 2022
Open
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request Jan 26, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonbrunel simonbrunel simonbrunel approved these changes

@benmccann benmccann benmccann left review comments

@etimberg etimberg etimberg left review comments

@kurkle kurkle kurkle left review comments

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
Version 2.9
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nagix @simonbrunel @benmccann @etimberg @kurkle