Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getValueForPixel in time scale #6328

Merged
merged 2 commits into from Jun 22, 2019
Merged

Conversation

nagix
Copy link
Contributor

@nagix nagix commented Jun 10, 2019

This PR fixes the following problems of getValueForPixel in time scale.

  • It doesn't support the ticks.reverse option
  • There is a bug in the offset calculation if offset is true

Master: https://jsfiddle.net/nagix/ot0npu3x/
Screen Shot 2019-06-10 at 8 30 13 AM

This PR: https://jsfiddle.net/nagix/gbd6sq92/
Screen Shot 2019-06-10 at 8 27 50 AM

kurkle
kurkle previously approved these changes Jun 10, 2019
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

etimberg
etimberg previously approved these changes Jun 10, 2019
src/scales/scale.time.js Outdated Show resolved Hide resolved
src/scales/scale.time.js Outdated Show resolved Hide resolved
@nagix nagix dismissed stale reviews from etimberg and kurkle via 612f55e June 14, 2019 23:33
@etimberg etimberg merged commit 1c85700 into chartjs:master Jun 22, 2019
@nagix nagix added this to the Version 2.9 milestone Jun 24, 2019
@nagix nagix deleted the issue-6328 branch June 24, 2019 10:50
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
* Fix getValueForPixel in time scale

* Minor refactoring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants