Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add radar chart config options #6393

Merged
merged 3 commits into from Jul 21, 2019
Merged

Add radar chart config options #6393

merged 3 commits into from Jul 21, 2019

Conversation

nagix
Copy link
Contributor

@nagix nagix commented Jul 17, 2019

The spanGaps option was missing in the radar chart configuration doc.

Fixes #6392

@nagix nagix mentioned this pull request Jul 17, 2019
Closed
3 tasks
etimberg
etimberg previously approved these changes Jul 18, 2019
View reviewed changes
benmccann
benmccann reviewed Jul 19, 2019
View reviewed changes
Copy link
Contributor

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine to me. just one minor comment

docs/charts/radar.md Outdated Show resolved Hide resolved
@etimberg etimberg merged commit 6632b8b into chartjs:master Jul 21, 2019
@simonbrunel simonbrunel added this to the Version 2.9 milestone Aug 23, 2019
@snyk-bot snyk-bot mentioned this pull request Nov 9, 2019
Merged
This was referenced Mar 4, 2020
Open
Open
@vpetersson vpetersson mentioned this pull request Mar 7, 2020
Merged
This was referenced Mar 9, 2020
Closed
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
This was referenced Apr 14, 2020
Open
Open
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
@nagix @etimberg
Add radar chart config options (chartjs#6393)
051fdbb 
* Add radar chart config options

* Add default value of spanGaps option for radar charts

* Address review comments
This was referenced Jun 1, 2021
Closed
Merged
Closed
Open
Closed
This was referenced Jun 6, 2021
Open
Open
This was referenced Jul 5, 2021
Closed
Open
This was referenced Jul 27, 2021
Closed
Merged
Merged
This was referenced Oct 14, 2021
Merged
Closed
@jw jw mentioned this pull request Jan 17, 2022
Open
1 task
This was referenced Jan 21, 2022
Merged
Closed
This was referenced Feb 4, 2022
Closed
Closed
This was referenced Mar 7, 2022
Open
Open
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request Jul 6, 2022
Closed
1 task
@mend-for-github-com mend-for-github-com bot mentioned this pull request Aug 13, 2022
Merged
1 task
This was referenced Nov 29, 2022
Open
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request Jan 26, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmccann benmccann benmccann approved these changes

@etimberg etimberg etimberg approved these changes

@simonbrunel simonbrunel Awaiting requested review from simonbrunel

@kurkle kurkle Awaiting requested review from kurkle

Assignees
No one assigned
Labels
type: documentation
Projects
None yet
Milestone
Version 2.9
Development

Successfully merging this pull request may close these issues.

spanGaps property for Radar chart
4 participants
@nagix @benmccann @etimberg @simonbrunel