From 543730c069bd49387744c351b6a7ceaafdb8d63e Mon Sep 17 00:00:00 2001 From: Akihiko Kusanagi Date: Thu, 18 Jul 2019 00:30:00 +0200 Subject: [PATCH 1/3] Add radar chart config options --- docs/charts/radar.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/docs/charts/radar.md b/docs/charts/radar.md index 90e05a55e83..8d66eb56424 100644 --- a/docs/charts/radar.md +++ b/docs/charts/radar.md @@ -143,7 +143,11 @@ The interaction with each point can be controlled with the following properties: ## Configuration Options -Unlike other charts, the radar chart has no chart specific options. +The radar chart defines the following configuration option. This option is merged with the global chart configuration option, `Chart.defaults.global`, to form the option passed to the chart. + +| Name | Type | Default | Description +| ---- | ---- | ------- | ----------- +| `spanGaps` | `boolean` | `false` | If false, NaN data causes a break in the line. ## Scale Options From 7f0015cc507696aad3c0a6304826b2f9ac9a631f Mon Sep 17 00:00:00 2001 From: Akihiko Kusanagi Date: Thu, 18 Jul 2019 00:51:07 +0200 Subject: [PATCH 2/3] Add default value of spanGaps option for radar charts --- src/controllers/controller.radar.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/controllers/controller.radar.js b/src/controllers/controller.radar.js index 57fd8267bd9..62763ff0980 100644 --- a/src/controllers/controller.radar.js +++ b/src/controllers/controller.radar.js @@ -8,6 +8,7 @@ var helpers = require('../helpers/index'); var valueOrDefault = helpers.valueOrDefault; defaults._set('radar', { + spanGaps: false, scale: { type: 'radialLinear' }, From 3baabab14264a64d291b33bc436976cb80f9b7ab Mon Sep 17 00:00:00 2001 From: Akihiko Kusanagi Date: Fri, 19 Jul 2019 22:46:31 +0200 Subject: [PATCH 3/3] Address review comments --- docs/charts/radar.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/charts/radar.md b/docs/charts/radar.md index 8d66eb56424..196d6b1eb72 100644 --- a/docs/charts/radar.md +++ b/docs/charts/radar.md @@ -143,7 +143,7 @@ The interaction with each point can be controlled with the following properties: ## Configuration Options -The radar chart defines the following configuration option. This option is merged with the global chart configuration option, `Chart.defaults.global`, to form the option passed to the chart. +The radar chart defines the following configuration options. These options are merged with the global chart configuration options, `Chart.defaults.global`, to form the options passed to the chart. | Name | Type | Default | Description | ---- | ---- | ------- | -----------