Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scale option examples for Radar Chart #6554

Merged

Conversation

indigolain
Copy link
Contributor

Adds more options to the example for the scale property in the documentation.

fixes #6553

etimberg
etimberg previously approved these changes Oct 5, 2019
Copy link
Contributor

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@@ -152,12 +152,17 @@ The radar chart defines the following configuration options. These options are m
## Scale Options

The radar chart supports only a single scale. The options for this scale are defined in the `scale` property.
The options for `scale` property can be refererenced from the [Linear Radial Axis page](../axes/radial/linear).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about rewording to:

The options for this scale are defined in the scale property, which can be referenced from the Linear Radial Axis page

("referenced" is spelled wrong, so make sure to update to the spelling I used)

docs/charts/radar.md Show resolved Hide resolved
@indigolain
Copy link
Contributor Author

@benmccann
Changed the wordings and examples according to your suggestions! Thanks!

@etimberg etimberg merged commit e9f3418 into chartjs:master Oct 6, 2019
@indigolain indigolain deleted the add_scale_option_example_for_radar_chart branch October 6, 2019 14:25
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add scale option examples for Radar Chart
3 participants