Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logarithmic test to use correct scale #6580

Merged
merged 1 commit into from Oct 19, 2019

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Oct 19, 2019

Test using correct scale. Using a scale that is not attached to given dataset should really not return any label for it.

This is extracted from #6576 to make the reviewing easier.

Copy link
Contributor

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in the commit message, but otherwise looks good

@kurkle kurkle changed the title Fix logarighmic test to use correct scale Fix logarithmic test to use correct scale Oct 19, 2019
@etimberg etimberg merged commit d386013 into chartjs:master Oct 19, 2019
@kurkle kurkle deleted the test-use-correct-scale branch November 13, 2019 06:12
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants