From af4bf6d630fc75caee758da19f3a2ea7f000425e Mon Sep 17 00:00:00 2001 From: kurkle Date: Thu, 31 Oct 2019 09:42:39 +0200 Subject: [PATCH 1/2] Backward compatible fill behavior for radar --- src/controllers/controller.radar.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/controllers/controller.radar.js b/src/controllers/controller.radar.js index 803c7fb7f62..dffe29e1507 100644 --- a/src/controllers/controller.radar.js +++ b/src/controllers/controller.radar.js @@ -14,6 +14,7 @@ defaults._set('radar', { }, elements: { line: { + fill: 'start', tension: 0 // no bezier in radar } } From 91a71d507d2722d22a83186bca2cc5e36689a893 Mon Sep 17 00:00:00 2001 From: kurkle Date: Thu, 31 Oct 2019 10:12:44 +0200 Subject: [PATCH 2/2] Fix tests --- test/fixtures/controller.radar/backgroundColor/scriptable.js | 1 + test/fixtures/controller.radar/backgroundColor/value.js | 1 + test/fixtures/controller.radar/borderDash/scriptable.js | 1 + 3 files changed, 3 insertions(+) diff --git a/test/fixtures/controller.radar/backgroundColor/scriptable.js b/test/fixtures/controller.radar/backgroundColor/scriptable.js index 4c714a45120..be2a29e76d9 100644 --- a/test/fixtures/controller.radar/backgroundColor/scriptable.js +++ b/test/fixtures/controller.radar/backgroundColor/scriptable.js @@ -25,6 +25,7 @@ module.exports = { title: false, elements: { line: { + fill: true, backgroundColor: function(ctx) { var index = (ctx.dataIndex === undefined ? ctx.datasetIndex : ctx.dataIndex); return index === 0 ? '#ff0000' diff --git a/test/fixtures/controller.radar/backgroundColor/value.js b/test/fixtures/controller.radar/backgroundColor/value.js index d9347ee5d73..dd118470d44 100644 --- a/test/fixtures/controller.radar/backgroundColor/value.js +++ b/test/fixtures/controller.radar/backgroundColor/value.js @@ -20,6 +20,7 @@ module.exports = { title: false, elements: { line: { + fill: true, backgroundColor: '#00ff00' }, point: { diff --git a/test/fixtures/controller.radar/borderDash/scriptable.js b/test/fixtures/controller.radar/borderDash/scriptable.js index 0bee9a8a669..8548c88e877 100644 --- a/test/fixtures/controller.radar/borderDash/scriptable.js +++ b/test/fixtures/controller.radar/borderDash/scriptable.js @@ -22,6 +22,7 @@ module.exports = { title: false, elements: { line: { + fill: true, borderColor: '#00ff00', borderDash: function(ctx) { return ctx.datasetIndex === 0 ? [5] : [10];