From bba7e4c143c2f56d442d123de3832a2170f67ca6 Mon Sep 17 00:00:00 2001 From: kurkle Date: Wed, 1 Dec 2021 21:30:59 +0200 Subject: [PATCH 1/2] Stop modifying options in interaction handlers --- src/core/core.interaction.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/core/core.interaction.js b/src/core/core.interaction.js index 5365f6c9108..d83b1ce58f0 100644 --- a/src/core/core.interaction.js +++ b/src/core/core.interaction.js @@ -322,8 +322,7 @@ export default { * @return {InteractionItem[]} - items that are found */ x(chart, e, options, useFinalPosition) { - options.axis = 'x'; - return getAxisItems(chart, e, options, useFinalPosition); + return getAxisItems(chart, e, {axis: 'x', ...options}, useFinalPosition); }, /** @@ -336,8 +335,7 @@ export default { * @return {InteractionItem[]} - items that are found */ y(chart, e, options, useFinalPosition) { - options.axis = 'y'; - return getAxisItems(chart, e, options, useFinalPosition); + return getAxisItems(chart, e, {axis: 'y', ...options}, useFinalPosition); } } }; From 2a310f3bb44a8967817c905055329ef49ac1d4a9 Mon Sep 17 00:00:00 2001 From: kurkle Date: Wed, 1 Dec 2021 21:37:41 +0200 Subject: [PATCH 2/2] Don't use object spread --- src/core/core.interaction.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/core/core.interaction.js b/src/core/core.interaction.js index d83b1ce58f0..0c37d1d8cdd 100644 --- a/src/core/core.interaction.js +++ b/src/core/core.interaction.js @@ -322,7 +322,7 @@ export default { * @return {InteractionItem[]} - items that are found */ x(chart, e, options, useFinalPosition) { - return getAxisItems(chart, e, {axis: 'x', ...options}, useFinalPosition); + return getAxisItems(chart, e, {axis: 'x', intersect: options.intersect}, useFinalPosition); }, /** @@ -335,7 +335,7 @@ export default { * @return {InteractionItem[]} - items that are found */ y(chart, e, options, useFinalPosition) { - return getAxisItems(chart, e, {axis: 'y', ...options}, useFinalPosition); + return getAxisItems(chart, e, {axis: 'y', intersect: options.intersect}, useFinalPosition); } } };