Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotations still broken when using array syntax #585

Closed
elitastic opened this issue Dec 21, 2021 · 5 comments
Closed

Annotations still broken when using array syntax #585

elitastic opened this issue Dec 21, 2021 · 5 comments

Comments

@elitastic
Copy link
Contributor

elitastic commented Dec 21, 2021

Annotations still look broken when using array syntax, have a look at the following codepen:

https://codepen.io/elitastic/pen/MWEvVYO

Styling is completely different when using array syntax!

Thanks a lot for any feedback!

@stockiNail
Copy link
Collaborator

I think it's still related to chartjs/Chart.js#9969 (not released yet).

The defaults are not applied because is looking in the lineAnnotation (default type) where some options are missing (backgroundColor, for instance).

I have tried some workarounds but without success (apart to use the object instead of the array).
@kurkle what do you think?

@LeeLenaleee
Copy link
Collaborator

What @stockiNail said is true, when using the master of chart.js and the annotation plugin it works fine:
https://codepen.io/leelenaleee/pen/eYGErrm

@elitastic
Copy link
Contributor Author

thank you for your quick replies! I thought by mistake this was fixed by the following workaround:

#575

So I'll wait for ChartJs 3.7 release, no problem.

@LeeLenaleee
Copy link
Collaborator

@elitastic 3.7 has been released and it works fine with the latest released version of annotation plugin for your issue: https://codepen.io/leelenaleee/pen/WNZZPoB

@elitastic
Copy link
Contributor Author

Great news, thanks for the info!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants