From 6357b848d91b68c16059852452082928e1b9e75b Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Thu, 29 Feb 2024 08:05:36 -0500 Subject: [PATCH 1/5] provide coverage in step summary (action script) Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- .github/workflows/coverage.yaml | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/.github/workflows/coverage.yaml b/.github/workflows/coverage.yaml index 2c1fed77b..62344baa4 100644 --- a/.github/workflows/coverage.yaml +++ b/.github/workflows/coverage.yaml @@ -55,10 +55,14 @@ jobs: const pr = ${{fromJson(needs.coverage.outputs.cov-pr).totals.percent_covered}}; const main = ${{fromJson(needs.coverage.outputs.cov-main).totals.percent_covered}}; const diff = pr - main; - github.rest.issues.createComment({ - issue_number: context.issue.number, - owner: context.repo.owner, - repo: context.repo.repo, - body: `### Coverage report - **Main**: ${main.toFixed(2)}% | **PR**: ${pr.toFixed(2)}% | **Diff: ${diff.toFixed(2)} ${diff >= 0 ? '✅' : '⚠️'}**` - }) + const report = `### Coverage report + **Main**: ${main.toFixed(2)}% | **PR**: ${pr.toFixed(2)}% | **Diff: ${diff.toFixed(2)} ${diff >= 0 ? '✅' : '⚠️'}**`; + if (context.issue.number) { + github.rest.issues.createComment({ + issue_number: context.issue.number, + owner: context.repo.owner, + repo: context.repo.repo, + body: report + }) + } + await core.summary.addRaw(report).write() From 9cb98aa7332769e4fe83ddf7d4d5bd1669ee9252 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Thu, 29 Feb 2024 08:06:12 -0500 Subject: [PATCH 2/5] add permissions for paranoid repositories to coverage report Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- .github/workflows/coverage.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/coverage.yaml b/.github/workflows/coverage.yaml index 62344baa4..c09949c42 100644 --- a/.github/workflows/coverage.yaml +++ b/.github/workflows/coverage.yaml @@ -2,6 +2,9 @@ name: coverage on: [push] +permissions: + contents: read + jobs: coverage: runs-on: ubuntu-latest @@ -48,6 +51,9 @@ jobs: comment: runs-on: ubuntu-latest needs: [coverage] + permissions: + pull-requests: write + steps: - uses: actions/github-script@v6 with: From eee85b11ecefe2e00ae683fec6d78b7cec9011c9 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Thu, 29 Feb 2024 10:07:53 -0500 Subject: [PATCH 3/5] tolerate failure to post comment in PRs from forks Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- .github/workflows/coverage.yaml | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/.github/workflows/coverage.yaml b/.github/workflows/coverage.yaml index c09949c42..581f3bbb1 100644 --- a/.github/workflows/coverage.yaml +++ b/.github/workflows/coverage.yaml @@ -64,11 +64,15 @@ jobs: const report = `### Coverage report **Main**: ${main.toFixed(2)}% | **PR**: ${pr.toFixed(2)}% | **Diff: ${diff.toFixed(2)} ${diff >= 0 ? '✅' : '⚠️'}**`; if (context.issue.number) { - github.rest.issues.createComment({ - issue_number: context.issue.number, - owner: context.repo.owner, - repo: context.repo.repo, - body: report - }) + try { + github.rest.issues.createComment({ + issue_number: context.issue.number, + owner: context.repo.owner, + repo: context.repo.repo, + body: report + }) + } catch (e) { + console.log("This happens when a PR from a fork triggers a workflow", e) + } } await core.summary.addRaw(report).write() From 154c15d088fcb6bf448aab2ded21fd8d6c141af3 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Thu, 7 Mar 2024 15:26:02 -0500 Subject: [PATCH 4/5] Add support for pull requests --- .github/workflows/coverage.yaml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/coverage.yaml b/.github/workflows/coverage.yaml index 581f3bbb1..d1530ef25 100644 --- a/.github/workflows/coverage.yaml +++ b/.github/workflows/coverage.yaml @@ -1,6 +1,8 @@ name: coverage -on: [push] +on: + push: + pull_request_target: permissions: contents: read @@ -18,7 +20,7 @@ jobs: - name: Checkout uses: actions/checkout@v3 with: - ref: ${{ matrix.branch == 'main' && 'main' || '' }} + ref: ${{ matrix.branch == 'main' && 'main' || (github.event.pull_request && format('refs/pull/{0}/merge', github.event.pull_request.number)) || '' }} - name: Bazel cache id: bazel-cache From 00cf0e13ddf05726e465440f3e6ebcabcafc040e Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Fri, 8 Mar 2024 07:25:03 -0500 Subject: [PATCH 5/5] Update api_beam_test.py --- temporian/test/api_beam_test.py | 1 + 1 file changed, 1 insertion(+) diff --git a/temporian/test/api_beam_test.py b/temporian/test/api_beam_test.py index 12ef96260..58aeb45ec 100644 --- a/temporian/test/api_beam_test.py +++ b/temporian/test/api_beam_test.py @@ -27,6 +27,7 @@ class TFPTest(absltest.TestCase): def test_run_base(self): tmp_dir = tempfile.mkdtemp() + input_path = os.path.join(tmp_dir, "input.csv") output_path = os.path.join(tmp_dir, "output.csv")