New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to create a reusable check-spelling action complete with configuration files #41
Comments
Hey @ricardo-dematos we've got both an action a workflow set up as a wrapper, please check out https://github.com/Lombiq/GitHub-Actions/blob/dev/Docs/Workflows.md#spelling-workflow! |
I'd generally add Do you have an action run I could look through? |
@BenedekFarkas your workflow uses the check-spelling action from the same repo, right? In my case I have a public repo with the check-spelling action and the idea is to use it from other organization repo's, thus sharing the dictionaries/configuration. Cloning the check-spelling action across the organization repo's does work, like you have experienced, but it's a dumb solution, because I'm repeating the dictionaries/configurations in each organization repo. |
@ricardo-dematos yes, so our https://github.com/Lombiq/GitHub-Actions/blob/dev/.github/actions/spelling/action.yml action is a wrapper for https://github.com/check-spelling/check-spelling/blob/main/action.yml with some extras to increase reusability of our base configuration in other repositories of ours:
For example, our Open-Source Orchard Core Extensions repository runs spell-checking in its Build and Test workflow and even though it doesn't have its own patterns.txt file, it will "inherit" https://github.com/Lombiq/GitHub-Actions/blob/dev/.github/actions/spelling/patterns.txt. Also, it has an excludes.txt file that will be extended with the entries from https://github.com/Lombiq/GitHub-Actions/blob/dev/.github/actions/spelling/excludes.txt. |
I'm trying to create a wrapper to check-spelling/check-spelling , with the intention of simplifying the inputs and outputs, while also providing a set of words valid in the Valispace software context.
It resides in valispace/actions/check-spelling, along with the Configuration: Files.
The main workflow has :
The action is :
This configuration does not read the Configuration: Files!
I've tried in the valispace/actions/check-spelling action :
config
to'./check-spelling'
config
with justspell_check_this: 'valispace/actions/check-spelling@master'
valispace/actions/check-spelling/.github/actions/spelling
tovalispace/actions/check-spelling
for the Configuration: FilesNone of this worked.
How can I make this work? 🧐
👉 In logs it seems that check-spelling/check-spelling is only capturing valispace/actions from setting
spell_check_this: 'valispace/actions/check-spelling@master'
.The text was updated successfully, but these errors were encountered: