Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add container test with Podman #73

Closed
wants to merge 2 commits into from
Closed

Add container test with Podman #73

wants to merge 2 commits into from

Conversation

snprajwal
Copy link
Member

This currently fails because I'm doing some container inception (trying to checkpoint a podman container running on a Fedora container in GH Actions). Not sure why CRIU is failing, and podman doesn't provide a verbose flag to log info about the checkpointing process.

Fixes #68

@github-actions
Copy link

Test Results

0 tests   - 24   0 ✔️  - 24   0s ⏱️ ±0s
0 suites  -   1   0 💤 ±  0 
0 files    -   1   0 ❌ ±  0 

Results for commit 505fc53. ± Comparison against base commit c3bcdc6.

@snprajwal
ci: use Ubuntu for all tests
a074f2f 
Checkpointing a podman container isn't possible if the GitHub workflow
runner is itself a container. This modifies both the test and coverage
workflows to use the Ubuntu runner instead.

Signed-off-by: Prajwal S N <prajwalnadig21@gmail.com>
@snprajwal
test: use Podman container checkpoint
95b266d 
Previously, we were only using a local process (piggie) to generate the
checkpoint for tests. Doing this with a container ensures more accurate
tests and higher coverage of edge cases in the implementation of
checkpointctl.

Signed-off-by: Prajwal S N <prajwalnadig21@gmail.com>
@snprajwal
Copy link
Member Author

Looks like GitHub runners don't support checkpointing with podman. The workflows throw an error for podman container checkpoint saying configured runtime does not support checkpoint/restore. We might have to use an external bare metal runner or a VM for this (maybe the CirrusCI instances we use with CRIU?)

@snprajwal snprajwal closed this Jul 6, 2023
@snprajwal snprajwal deleted the add-container-test branch July 6, 2023 08:24
@adrianreber
Copy link
Member

Looks like GitHub runners don't support checkpointing with podman. The workflows throw an error for podman container checkpoint saying configured runtime does not support checkpoint/restore. We might have to use an external bare metal runner or a VM for this (maybe the CirrusCI instances we use with CRIU?)

The version of crun probably has not been compiled with CRIU support. Just switching to runc should already fix this.

@snprajwal snprajwal restored the add-container-test branch July 6, 2023 15:02
@snprajwal
Copy link
Member Author

snprajwal commented Jul 6, 2023 •
edited

Using runc lets us checkpoint, but the stats-dump file is missing for some reason. Not sure why. The logs are available here: https://github.com/snprajwal/checkpointctl/actions/runs/5477217792/jobs/9975920598#step:6:50

I am also passing -k to preserve CRIU statistics files, but that didn't change the output.

@adrianreber
Copy link
Member

Maybe the Podman version is too old. We added support for statistics not from the beginning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add integration test with podman
2 participants
@snprajwal @adrianreber