Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide unused sections when searching for an account #513

Open
wakest opened this issue Apr 20, 2024 · 3 comments
Open

hide unused sections when searching for an account #513

wakest opened this issue Apr 20, 2024 · 3 comments
Labels

Comments

@wakest
Copy link

wakest commented Apr 20, 2024

when searching for a url, the second you have a result you know that it isn't a hashtag or a post, so it makes sense to then not show those categories after phanpy knows what its searching for...

image

Version
https://dev.phanpy.social/ build 2024.04.19.7376cb1
Mastodon account: https://social.wake.st/@liaizon
macOS 13.6.4
Firefox 124.0.2 (64-bit)

@wakest wakest changed the title dont display hashtag and post sections when searching for an account hide unused sections when searching for an account Apr 20, 2024
@cheeaun cheeaun added the design label Apr 20, 2024
@cheeaun
Copy link
Owner

cheeaun commented Apr 20, 2024

it makes sense to then not show those categories

This is subjective. Hiding them also means there's no (visual) hint that no results are found for those categories and can be thought as a bug.

@wakest
Copy link
Author

wakest commented Apr 22, 2024

if you search for a link there can never be results for a hashtag right? so why would you need a hint that theres no results for something that there can never be results for?

@cheeaun
Copy link
Owner

cheeaun commented Apr 22, 2024

if you search for a link there can never be results for a hashtag right?

True, but still depends on the backend 😉 (they could return something? 😂). I know we can try to be smart about this but as of now, I'll keep this in mind and continue observing user behaviour/feedback. This search page is still "under-designed" and there are various ways to further improve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants