fix(manipulation): .html should move passed nodes (#1923)

Fixes #940.
cheeriojs · Jun 8, 2021 · 258b26b · 258b26b
1 parent 5cd2b9c
commit 258b26b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/api/manipulation.spec.ts b/src/api/manipulation.spec.ts
@@ -1770,6 +1770,13 @@ describe('$(...)', () => {
       expect(html).toBe('<li class="durian">Durian</li>');
     });
 
+    it('(elem) : should move the passed element (#940)', () => {
+      $('.apple').html($('.orange'));
+      expect($fruits.html()).toBe(
+        '<li class="apple"><li class="orange">Orange</li></li><li class="pear">Pear</li>'
+      );
+    });
+
     it('() : should allow element reinsertion', () => {
       const $children = $fruits.children();
 

diff --git a/src/api/manipulation.ts b/src/api/manipulation.ts
@@ -939,7 +939,7 @@ export function html<T extends Node>(
     opts.context = el;
 
     const content = isCheerio(str)
-      ? str.clone().get()
+      ? str.toArray()
       : parse(`${str}`, opts, false).children;
 
     updateDOM(content, el);