Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Android adaptive icons? #91

Open
Klowner opened this issue May 9, 2023 · 1 comment
Open

Support for Android adaptive icons? #91

Klowner opened this issue May 9, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@Klowner
Copy link

Klowner commented May 9, 2023

Greetings! Thank you for all the very excellent work on this library!

Just curious if there are plans to add support for Android adaptive icons. If not, I would be happy to open a PR.

When parsing an APK with app-info-parser v1.1.2, the icon returned in the results is an ic_launcher.xml file. It is simple enough to parse that binary XML file to obtain the relevant foreground, background, or monochrome drawables (typically PNGs).

If support is desirable, would it make sense to extract the individual maximally sized icons (similar to findApkIconPath()) for each category (background, foreground, monochrome) so the user could potentially take further action? This would likely necessitate a change in the structure for the parsed result object, unless only the foreground image were returned?

Any input is appreciated!

-Mark

@chenquincy
Copy link
Owner

@Klowner That's a good feature, but I'm busy in my main job recently. Welcome to contribute your code. You can create PR whenever you want, I will review and merge it as soon as I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants