Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only applies to methods, not members #11

Open
simonhaenisch opened this issue Sep 30, 2018 · 1 comment
Open

Only applies to methods, not members #11

simonhaenisch opened this issue Sep 30, 2018 · 1 comment

Comments

@simonhaenisch
Copy link

export class FooBar {
  foo;
  bar;
}

This doesn't report anything even though there is no new line between the members foo and bar.

If this rule is only for class methods, it should maybe not be named lines-between-class-members?

Would be nice to make it work for any type of member and then you could make it configurable in case someone only wants it to apply to methods.

@chinchiheather
Copy link
Owner

Hi @simonhaenisch, yeah I did initially have it named as lines-between-class-methods because it does only relate to class methods. But as I based it on the eslint rule which is called lines-between-class-members (and also only affects methods) I thought it would be easier for people to find if it had the same name. I was in two minds about it though.

I have no issue with your suggestion about adding this in for all class members, however I don't think I have time to get round to it right now, but if you would like to make a PR that would be awesome :) I would say it is more likely that people would not want lines between variables though, so the configuration should be to add it in rather than disable it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants