Duplicate or wrong event binding (keydown)

[thekikao]

Your Environment

• flatpickr version used: 4.5.0
• Browser name and version: 67.0.x

It seems like there is a duplicate or wrong event binding.

The keydown event is falsely bound to the window.document.body:

flatpickr/src/index.ts

Line 412 in 91756bb

bind(window.document.body, "keydown", onKeyDown);

but the correct binding to the input field is already set at the next line:

flatpickr/src/index.ts

Line 414 in 91756bb

if (!self.config.static) bind(self._input, "keydown", onKeyDown);

This results in firing the onKeyDown function on every keypress at the whole page.
A simple removing line 412 should prevent the keydown-event-firework if multiple instances of the picker are used at a time.

Expected

Firing the keydown event only if the flatpickr has focus.

Observed

Firing the keydown on every keypress at the whole page. Numerous if multiple pickers are used.

Solution

Removing line 412 at flatpickr/src/index.ts

[ghiscoding]

This should be reopen and should have been followed according to the original proposition, the current keyDown event is bound to window.body and this is crazy bad, that means that even if the element is not a Flatpickr element, it will still go through that onKeyDown handler, this is bad, bad and is not following the separation of concerns, this is considered leak... and it slows down someone's Angular App using my lib (Flatpickr is a dependency of my lib Angular-Slickgrid) as shown in this post

bind(window.document.body, "keydown", onKeyDown);