Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confetti.js Running Based on Build Date Instead of Current Date #9

Open
choubari opened this issue Sep 27, 2023 · 1 comment
Open
Labels
good first issue Good for newcomers

Comments

@choubari
Copy link
Owner

The confetti.js script is designed to run only on my birthday (if todayDate === birthdayDate).

However, it currently checks against the date when the page was last built (todayDate = buildDate).

This means that if the site is built on my birthday, the script runs continuously until the next build.

Conversely, if built before my birthday, the script might not run at all on the day. We need a way to make it check against the actual current date.

@choubari choubari added the good first issue Good for newcomers label Sep 27, 2023
@choubari
Copy link
Owner Author

While triggering a rebuild/redeploy via GitHub Actions (or manually 🫠) is a valid approach, it might not be the most efficient.

Using client-side JavaScript to check the current date directly might be a more resource-saving and consistent solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant