Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing lists for VoiceOver πŸ€¦πŸ»β€β™€οΈ #37

Open
chris-pearce opened this issue Jan 12, 2019 · 2 comments
Open
Labels
a11y 🌏 Everything related to accessibility. lib: text-content πŸŽ’ Everything related to the lib's "Text Content" section. need-more-info ❓ Sorry, more info is needed to better understand this issue.

Comments

@chris-pearce
Copy link
Owner

chris-pearce commented Jan 12, 2019

See here:

I really don't like this and agree 100% with this tweet. But caring about accessibility I feel my hands are tied.

Here is the related code:

/*
* In applications lists are ubiquitous and it's extremely rare they're used in
* long form content therefore it makes sense to strip away their bullets in
* addition to removing their default margin and padding (see: Resets).
*/
ul,
ol {
list-style-type: none;
}

@chris-pearce chris-pearce added lib: text-content πŸŽ’ Everything related to the lib's "Text Content" section. a11y 🌏 Everything related to accessibility. labels Jan 12, 2019
@chris-pearce
Copy link
Owner Author

Reading into this more I'm now leaning to not doing this as it seems the fix can cause issues in rendering and the alternative SVG fix doesn't feel as well tested (yet). Will leave this open for now.

@chris-pearce chris-pearce added the need-more-info ❓ Sorry, more info is needed to better understand this issue. label Jan 18, 2019
@chris-pearce chris-pearce added the next-major-version ✨ Use this to mark items for the next major version label Apr 4, 2020
@chris-pearce
Copy link
Owner Author

I delved into this pretty deeply and discovered that the pseudo-element fix doesn't do anything in the latest Safari. You need to combine it with the SVG treatment sanitize.css applies. However, this only works for unordered lists, ordered lists incorrectly get acknowledged as unordered lists.

I'm going to leave this open for now.

@chris-pearce chris-pearce removed the next-major-version ✨ Use this to mark items for the next major version label Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y 🌏 Everything related to accessibility. lib: text-content πŸŽ’ Everything related to the lib's "Text Content" section. need-more-info ❓ Sorry, more info is needed to better understand this issue.
Projects
None yet
Development

No branches or pull requests

1 participant