Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android SDK 31 blur freeze #146

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gleb-skobinsky
Copy link

This pull request fixes #77.
The rendering freeze appears to be related to the JNI interop level, as the native layer tries to optimize out changes if they are translated but no position changes are involved.

@gleb-skobinsky gleb-skobinsky marked this pull request as draft March 1, 2024 08:53
@gleb-skobinsky
Copy link
Author

Unfortunately, it turns out this fix works for samples where position is updated (credit card), but still doesn't for samples where the background is updated, but the position remains the same (scaffold).

@chrisbanes
Copy link
Owner

Unfortunately, it turns out this fix works for samples where position is updated (credit card), but still doesn't for samples where the background is updated, but the position remains the same (scaffold).

I don't think we can re-enable this if static content isn't working. I'll play around with this over the weekend and see if we can add something to force the RenderNode to invalidate.

@gleb-skobinsky
Copy link
Author

Unfortunately, it turns out this fix works for samples where position is updated (credit card), but still doesn't for samples where the background is updated, but the position remains the same (scaffold).

I don't think we can re-enable this if static content isn't working. I'll play around with this over the weekend and see if we can add something to force the RenderNode to invalidate.

Yes, this is not a solution that produces a consistent result. Sorry for the fuss. Need to investigate further

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blur frozen on Android API 31
2 participants