From 98a12ee6728f8d98c9b20f3a575a25af6626f725 Mon Sep 17 00:00:00 2001 From: Chris Bobbe Date: Mon, 24 Aug 2020 17:02:12 -0700 Subject: [PATCH] Jest setup: Stop polyfilling Promise. It looks like this line was introduced in 3ff3987, in 2015, and it has remained in a similar form since then. I haven't found any explanation for it. At facebook/jest#10221 [1], a core Jest maintainer says, """ As an aside, one should never replace `global.Promise` [...]. E.g. when using `async-await` you will always get the native `Promise` regardless of the value of `global.Promise`. """ facebook/jest#10221 is one issue this line has raised, for anyone using the latest features of Jest to test async code in their React Native projects. [1] https://github.com/facebook/jest/issues/10221#issuecomment-654687396 Fixes: #29303 --- android/com/facebook/react/react-native/maven-metadata.xml | 2 +- android/com/facebook/react/react-native/maven-metadata.xml.md5 | 2 +- android/com/facebook/react/react-native/maven-metadata.xml.sha1 | 2 +- jest/setup.js | 1 - 4 files changed, 3 insertions(+), 4 deletions(-) diff --git a/android/com/facebook/react/react-native/maven-metadata.xml b/android/com/facebook/react/react-native/maven-metadata.xml index 972fd99b42e0be..1371024db30fbf 100644 --- a/android/com/facebook/react/react-native/maven-metadata.xml +++ b/android/com/facebook/react/react-native/maven-metadata.xml @@ -7,6 +7,6 @@ 0.61.5 - 20200825180753 + 20200825182101 diff --git a/android/com/facebook/react/react-native/maven-metadata.xml.md5 b/android/com/facebook/react/react-native/maven-metadata.xml.md5 index 5c5c1834577890..4be7bca9ea4935 100644 --- a/android/com/facebook/react/react-native/maven-metadata.xml.md5 +++ b/android/com/facebook/react/react-native/maven-metadata.xml.md5 @@ -1 +1 @@ -aa57f1b2f064dca23b4b122f2715a941 \ No newline at end of file +1f448be785da145276a61b82175013d2 \ No newline at end of file diff --git a/android/com/facebook/react/react-native/maven-metadata.xml.sha1 b/android/com/facebook/react/react-native/maven-metadata.xml.sha1 index 2be1f5051db06a..05f137274d0e49 100644 --- a/android/com/facebook/react/react-native/maven-metadata.xml.sha1 +++ b/android/com/facebook/react/react-native/maven-metadata.xml.sha1 @@ -1 +1 @@ -3a98ee4afadae726bc5c9805698318f8897bbfca \ No newline at end of file +070de441ae93253fc1f611eb8048757028197644 \ No newline at end of file diff --git a/jest/setup.js b/jest/setup.js index 954d9fd76d2740..a6195ad4fa2e62 100644 --- a/jest/setup.js +++ b/jest/setup.js @@ -17,7 +17,6 @@ jest.requireActual('../Libraries/polyfills/error-guard'); global.__DEV__ = true; -global.Promise = jest.requireActual('promise'); global.regeneratorRuntime = jest.requireActual('regenerator-runtime/runtime'); global.requestAnimationFrame = function(callback) {