Change subscription attributes presence checks

chriskalmar · May 13, 2020 · e8472d5 · e8472d5
1 parent 6b628cd
commit e8472d5
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 23 deletions.
diff --git a/src/engine/subscription/Subscription.spec.ts b/src/engine/subscription/Subscription.spec.ts
@@ -250,7 +250,8 @@ describe('Subscription', () => {
       expect(fn).toThrowErrorMatchingSnapshot();
     });
 
-    it('should throw if required attribute is missing in CREATE type subscriptions', () => {
+    // this check seems useless for subscription
+    it.skip('should throw if required attribute is missing in CREATE type subscriptions', () => {
       function fn() {
         const otherEntity = new Entity({
           name: 'SomeEntityName',

diff --git a/src/engine/subscription/Subscription.ts b/src/engine/subscription/Subscription.ts
@@ -125,16 +125,17 @@ export class Subscription {
 
     if (this.type === SUBSCRIPTION_TYPE_CREATE) {
       this.isTypeCreate = true;
+      this.ignoreRequired = true;
     }
 
     if (this.type === SUBSCRIPTION_TYPE_UPDATE) {
-      this.needsInstance = true;
+      // this.needsInstance = true;
       this.ignoreRequired = true;
       this.isTypeUpdate = true;
     }
 
     if (this.type === SUBSCRIPTION_TYPE_DELETE) {
-      this.needsInstance = true;
+      // this.needsInstance = true;
       this.isTypeDelete = true;
     }
 
@@ -241,24 +242,23 @@ export const processEntitySubscriptions = (
         );
       });
 
-      if (subscription.type === SUBSCRIPTION_TYPE_CREATE) {
-        // todo : remove this check ?
-        const missingAttributeNames = requiredAttributeNames.filter(
-          requiredAttributeName => {
-            return !subscription.attributes.includes(requiredAttributeName);
-          },
-        );
-
-        passOrThrow(
-          missingAttributeNames.length === 0,
-          () =>
-            `Missing required attributes in subscription '${entity.name}.${
-              subscription.name
-            }' need to have a defaultValue() function: [ ${missingAttributeNames.join(
-              ', ',
-            )} ]`,
-        );
-      }
+      // if (subscription.type === SUBSCRIPTION_TYPE_CREATE) {
+      //   const missingAttributeNames = requiredAttributeNames.filter(
+      //     requiredAttributeName => {
+      //       return !subscription.attributes.includes(requiredAttributeName);
+      //     },
+      //   );
+
+      //   passOrThrow(
+      //     missingAttributeNames.length === 0,
+      //     () =>
+      //       `Missing required attributes in subscription '${entity.name}.${
+      //         subscription.name
+      //       }' need to have a defaultValue() function: [ ${missingAttributeNames.join(
+      //         ', ',
+      //       )} ]`,
+      //   );
+      // }
     } else if (
       subscription.type === SUBSCRIPTION_TYPE_CREATE ||
       subscription.type === SUBSCRIPTION_TYPE_UPDATE

diff --git a/src/engine/subscription/__snapshots__/Subscription.spec.ts.snap b/src/engine/subscription/__snapshots__/Subscription.spec.ts.snap
@@ -9,6 +9,7 @@ Subscription {
   ],
   "delimiter": "/",
   "description": "build item",
+  "ignoreRequired": true,
   "isTypeCreate": true,
   "name": "SomeSubWithPostProcessor",
   "postProcessor": [Function],
@@ -67,6 +68,7 @@ Subscription {
   ],
   "delimiter": "/",
   "description": "build item",
+  "ignoreRequired": true,
   "isTypeCreate": true,
   "name": "SomeSubWithPreProcessor",
   "preProcessor": [Function],

diff --git a/src/graphqlProtocol/__snapshots__/generator.spec.ts.snap b/src/graphqlProtocol/__snapshots__/generator.spec.ts.snap
@@ -38,10 +38,8 @@ GraphQLSchema {
     "OnCreateTestEntityNameInstanceNestedInput": "OnCreateTestEntityNameInstanceNestedInput",
     "OnCreateTestEntityNameNestedInput": "OnCreateTestEntityNameNestedInput",
     "OnCreateTestEntityNameOutput": "OnCreateTestEntityNameOutput",
-    "OnDeleteTestEntityNameByIdInput": "OnDeleteTestEntityNameByIdInput",
     "OnDeleteTestEntityNameInput": "OnDeleteTestEntityNameInput",
     "OnDeleteTestEntityNameOutput": "OnDeleteTestEntityNameOutput",
-    "OnUpdateTestEntityNameByIdInput": "OnUpdateTestEntityNameByIdInput",
     "OnUpdateTestEntityNameInput": "OnUpdateTestEntityNameInput",
     "OnUpdateTestEntityNameInstanceInput": "OnUpdateTestEntityNameInstanceInput",
     "OnUpdateTestEntityNameInstanceNestedInput": "OnUpdateTestEntityNameInstanceNestedInput",