Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory usage increases over time #110

Open
tttech-miori opened this issue Aug 4, 2022 · 6 comments
Open

Memory usage increases over time #110

tttech-miori opened this issue Aug 4, 2022 · 6 comments

Comments

@tttech-miori
Copy link

tttech-miori commented Aug 4, 2022

It appears that XCP is increasing memory usage over time.

I actually could find at least a couple of spots where allocation happens while never freeing:

  • self.evQueue.append(response) (line 292 of base.py)
  • self.servQueue.append(response) (line 295 of base.py,)
  • self.daqQueue.append (line 314 of base.py)

As far as I understand these queues are mostly / only used for testing only. Is that the case?

As a workaround in my application I can definitely deque them from time to time but it would be nicer to handle that internally / enable them only for debug.

@tttech-miori
Copy link
Author

version 0.18.48

@danielhrisca
Copy link
Contributor

  • self.evQueue.append(response) (line 292 of base.py)
  • self.servQueue.append(response) (line 295 of base.py,)
  • self.daqQueue.append (line 314 of base.py)

In the current implementation you should consume those queues. All the ODTs are placed in the daqQueue

@tttech-miori
Copy link
Author

I see, thanks for the prompt answer!

Do you think this is going to be changed in the future?

@danielhrisca
Copy link
Contributor

I don't think so

@christoph2
Copy link
Owner

Currently work in progress -- there'll be a much more flexible callback/callout mechanism in the (near) future.
The rekorder extension is one step in this direction (unfortunatly, there are still some C++ - Python integration issues).

@tttech-miori
Copy link
Author

Thank you for the answers!
Have a nice day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants