@pob/eslint-config-typescript-react/CHANGELOG.md

@@ -3,6 +3,13 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [55.0.1](https://github.com/christophehurpeau/eslint-config-pob/compare/v55.0.0...v55.0.1) (2024-04-21)
+
+Note: no notable changes
+
+
+
+
 ## [55.0.0](https://github.com/christophehurpeau/eslint-config-pob/compare/v54.0.2...v55.0.0) (2024-04-20)
 
 

@pob/eslint-config-typescript-react/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pob/eslint-config-typescript-react",
-  "version": "55.0.0",
+  "version": "55.0.1",
   "description": "eslint config files",
   "keywords": [],
   "author": "Christophe Hurpeau <christophe@hurpeau.com> (http://christophe.hurpeau.com/)",
@@ -58,7 +58,7 @@
     }
   },
   "dependencies": {
-    "@pob/eslint-config": "55.0.0",
+    "@pob/eslint-config": "55.0.1",
     "eslint-plugin-import": "2.29.1",
     "eslint-plugin-jsx-a11y": "6.8.0",
     "eslint-plugin-react": "7.34.1",

@pob/eslint-config-typescript/CHANGELOG.md

@@ -3,6 +3,13 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [55.0.1](https://github.com/christophehurpeau/eslint-config-pob/compare/v55.0.0...v55.0.1) (2024-04-21)
+
+Note: no notable changes
+
+
+
+
 ## [55.0.0](https://github.com/christophehurpeau/eslint-config-pob/compare/v54.0.2...v55.0.0) (2024-04-20)
 
 

@pob/eslint-config-typescript/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pob/eslint-config-typescript",
-  "version": "55.0.0",
+  "version": "55.0.1",
   "description": "eslint config files",
   "keywords": [],
   "author": "Christophe Hurpeau <christophe@hurpeau.com> (http://christophe.hurpeau.com/)",
@@ -59,7 +59,7 @@
     }
   },
   "dependencies": {
-    "@pob/eslint-config": "55.0.0",
+    "@pob/eslint-config": "55.0.1",
     "@typescript-eslint/eslint-plugin": "^7.7.0",
     "@typescript-eslint/parser": "^7.7.0",
     "eslint-plugin-import": "^2.29.1",

@pob/eslint-config/CHANGELOG.md

@@ -3,6 +3,16 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [55.0.1](https://github.com/christophehurpeau/eslint-config-pob/compare/v55.0.0...v55.0.1) (2024-04-21)
+
+
+### Bug Fixes
+
+* properly configure module vs commonjs ([0094461](https://github.com/christophehurpeau/eslint-config-pob/commit/0094461a633be153a734a4f52cfaa548f92a6e1e))
+
+
+
+
 ## [55.0.0](https://github.com/christophehurpeau/eslint-config-pob/compare/v54.0.2...v55.0.0) (2024-04-20)
 
 

@pob/eslint-config/lib/_base.js

@@ -0,0 +1,16 @@
+'use strict';
+
+module.exports = {
+  extends: [
+    'eslint:recommended',
+    ...[
+      './plugins/unicorn',
+      './rules/best-practices',
+      './rules/code-quality',
+      './rules/errors',
+      './rules/style',
+      './plugins/import/import-base',
+      './plugins/import/import-commonjs',
+    ].map(require.resolve),
+  ],
+};

@pob/eslint-config/lib/base/commonjs.js

@@ -0,0 +1,10 @@
+'use strict';
+
+module.exports = {
+  parserOptions: {
+    sourceType: 'script',
+  },
+  rules: {
+    strict: ['error', 'safe'],
+  },
+};

@pob/eslint-config/lib/base/module.js

@@ -0,0 +1,10 @@
+'use strict';
+
+module.exports = {
+  parserOptions: {
+    sourceType: 'module',
+  },
+  rules: {
+    strict: 'off',
+  },
+};

@pob/eslint-config/lib/index.js

@@ -1,3 +1,20 @@
 'use strict';
 
-module.exports = require('./base');
+module.exports = {
+  extends: ['./_base', './base/commonjs'].map(require.resolve),
+
+  overrides: [
+    {
+      files: ['*.mjs'],
+      extends: ['./base/module', './plugins/import/import-module'].map(
+        require.resolve,
+      ),
+    },
+    {
+      files: ['*.cjs'],
+      extends: ['./base/commonjs', './plugins/import/import-commonjs'].map(
+        require.resolve,
+      ),
+    },
+  ],
+};

@pob/eslint-config/lib/node-commonjs.js

@@ -1,5 +1,25 @@
 'use strict';
 
 module.exports = {
-  extends: ['./base', './node/commonjs'].map(require.resolve),
+  extends: [
+    './_base',
+    './base/commonjs',
+    './plugins/import/import-commonjs',
+    './node/commonjs',
+  ].map(require.resolve),
+
+  overrides: [
+    {
+      files: ['*.mjs'],
+      extends: [
+        './_base',
+        './base/module',
+        './plugins/import/import-module',
+        './node/module',
+      ].map(require.resolve),
+    },
+    {
+      files: ['*.cjs'],
+    },
+  ],
 };

@pob/eslint-config/lib/node-module.js

@@ -1,7 +1,25 @@
 'use strict';
 
 module.exports = {
-  extends: ['./base', './plugins/import/import-module', './node/module'].map(
-    require.resolve,
-  ),
+  extends: [
+    './_base',
+    './base/module',
+    './plugins/import/import-module',
+    './node/module',
+  ].map(require.resolve),
+
+  overrides: [
+    {
+      files: ['*.cjs'],
+      extends: [
+        './_base',
+        './base/commonjs',
+        './plugins/import/import-commonjs',
+        './node/commonjs',
+      ].map(require.resolve),
+    },
+    {
+      files: ['*.mjs'],
+    },
+  ],
 };

@pob/eslint-config/lib/node/commonjs.js

@@ -21,32 +21,4 @@ module.exports = {
     'n/no-new-require': 'error',
     'n/no-path-concat': 'error',
   },
-
-  overrides: [
-    {
-      files: ['*.mjs'],
-      extends: ['plugin:n/recommended-module'],
-      parserOptions: {
-        sourceType: 'module',
-        ecmaVersion: 2022,
-      },
-      rules: {
-        ...overrideRules,
-        'unicorn/prefer-module': 'error',
-        'import/extensions': [
-          'error',
-          'ignorePackages',
-          {
-            mjs: 'always',
-            cjs: 'always',
-            js: 'always',
-          },
-        ],
-      },
-    },
-    {
-      files: ['*.cjs'],
-      rules: {},
-    },
-  ],
 };

@pob/eslint-config/lib/node/module.js

@@ -30,24 +30,4 @@ module.exports = {
       },
     ],
   },
-
-  overrides: [
-    {
-      files: ['*.mjs'],
-      rules: {},
-    },
-    {
-      files: ['*.cjs'],
-      extends: ['plugin:n/recommended-script'],
-      parserOptions: {
-        sourceType: 'script',
-        ecmaVersion: 2022,
-      },
-      rules: {
-        strict: ['error', 'safe'],
-        ...overrideRules,
-        'unicorn/prefer-module': 'off',
-      },
-    },
-  ],
 };

@pob/eslint-config/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pob/eslint-config",
-  "version": "55.0.0",
+  "version": "55.0.1",
   "description": "eslint config files",
   "keywords": [],
   "author": "Christophe Hurpeau <christophe@hurpeau.com> (http://christophe.hurpeau.com/)",
@@ -18,7 +18,7 @@
   "sideEffects": false,
   "main": "./lib/index.js",
   "exports": {
-    ".": "./lib/base.js",
+    ".": "./lib/index.js",
     "./node-commonjs": "./lib/node-commonjs.js",
     "./node-module": "./lib/node-module.js",
     "./root-commonjs": "./lib/root-commonjs.js",

CHANGELOG.md

@@ -3,6 +3,14 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [55.0.1](https://github.com/christophehurpeau/eslint-config-pob/compare/v55.0.0...v55.0.1) (2024-04-21)
+
+
+### Bug Fixes
+
+* properly configure module vs commonjs ([0094461](https://github.com/christophehurpeau/eslint-config-pob/commit/0094461a633be153a734a4f52cfaa548f92a6e1e))
+
+
 ## [55.0.0](https://github.com/christophehurpeau/eslint-config-pob/compare/v54.0.2...v55.0.0) (2024-04-20)
 
 

package.json

@@ -1,7 +1,7 @@
 {
   "name": "@pob/eslint-config-monorepo",
   "private": true,
-  "version": "55.0.0",
+  "version": "55.0.1",
   "description": "pob eslint configs",
   "author": "Christophe Hurpeau <christophe@hurpeau.com> (http://christophe.hurpeau.com/)",
   "license": "ISC",

yarn.lock

@@ -391,7 +391,7 @@ __metadata:
   version: 0.0.0-use.local
   resolution: "@pob/eslint-config-typescript-react@workspace:@pob/eslint-config-typescript-react"
   dependencies:
-    "@pob/eslint-config": "npm:55.0.0"
+    "@pob/eslint-config": "npm:55.0.1"
     "@types/react": "npm:18.2.79"
     eslint-plugin-import: "npm:2.29.1"
     eslint-plugin-jsx-a11y: "npm:6.8.0"
@@ -420,7 +420,7 @@ __metadata:
   version: 0.0.0-use.local
   resolution: "@pob/eslint-config-typescript@workspace:@pob/eslint-config-typescript"
   dependencies:
-    "@pob/eslint-config": "npm:55.0.0"
+    "@pob/eslint-config": "npm:55.0.1"
     "@typescript-eslint/eslint-plugin": "npm:7.7.0"
     "@typescript-eslint/parser": "npm:7.7.0"
     eslint: "npm:8.57.0"
@@ -444,7 +444,7 @@ __metadata:
   languageName: unknown
   linkType: soft
 
-"@pob/eslint-config@npm:55.0.0, @pob/eslint-config@workspace:@pob/eslint-config":
+"@pob/eslint-config@npm:55.0.1, @pob/eslint-config@workspace:@pob/eslint-config":
   version: 0.0.0-use.local
   resolution: "@pob/eslint-config@workspace:@pob/eslint-config"
   dependencies: