Skip to content

Commit 434d5b3

Browse files
authoredApr 21, 2024··
feat(deps): update @pob/eslint-config to v55 (major) (#2020)

File tree

12 files changed

+182
-213
lines changed

12 files changed

+182
-213
lines changed
 

‎@pob/codemods/lib/transforms/jest-to-node-runner.cjs

+1
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,7 @@ module.exports = (file, api, options) => {
119119
.find(j.ImportDeclaration, { source: { value: 'node:assert' } })
120120
.remove();
121121
if (
122+
// eslint-disable-next-line no-constant-condition
122123
(!root.find(j.ImportDeclaration),
123124
{ source: { value: 'node:assert/strict' } })
124125
) {

‎@pob/root/createLintStagedConfig.js

+1
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,5 @@ import { createRequire } from 'node:module';
22

33
const require = createRequire(import.meta.url);
44

5+
// eslint-disable-next-line import/no-commonjs
56
export default require('./createLintStagedConfig.cjs');

‎@pob/sort-object/lib/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ export default function sortObject(obj, keys = []) {
44
const objKeys = Object.keys(obj);
55
objKeys.forEach((key) => delete obj[key]);
66
[
7-
...keys.filter((key) => Object.hasOwnProperty.call(objCopy, key)),
7+
...keys.filter((key) => Object.hasOwn(objCopy, key)),
88
...objKeys.sort((a, b) => a.toLowerCase().localeCompare(b.toLowerCase())),
99
].forEach((key) => {
1010
obj[key] = objCopy[key];

‎package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
"prettier": "@pob/root/prettier-config",
4343
"devDependencies": {
4444
"@babel/core": "7.24.4",
45-
"@pob/eslint-config": "54.0.1",
45+
"@pob/eslint-config": "55.0.1",
4646
"@pob/root": "workspace:*",
4747
"@types/jest": "29.5.12",
4848
"check-package-dependencies": "7.1.1",

‎packages/babel-preset-pob-env/lib/index.js

+3
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,9 @@ export default function (context, opts = {}) {
116116
case false:
117117
targetPreset = null;
118118
break;
119+
120+
default:
121+
throw new Error('Invalid target');
119122
}
120123

121124
return {

‎packages/pob-dependencies/package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,9 @@
4545
"@playwright/test": "1.43.1",
4646
"@pob/commitlint-config": "6.3.1",
4747
"@pob/esbuild": "1.0.0-pre",
48-
"@pob/eslint-config": "54.0.1",
49-
"@pob/eslint-config-typescript": "54.0.2",
50-
"@pob/eslint-config-typescript-react": "54.0.2",
48+
"@pob/eslint-config": "55.0.1",
49+
"@pob/eslint-config-typescript": "55.0.1",
50+
"@pob/eslint-config-typescript-react": "55.0.1",
5151
"@pob/pretty-pkg": "7.0.0",
5252
"@pob/rollup-esbuild": "1.0.0-pre",
5353
"@pob/rollup-typescript": "2.2.2",

‎packages/pob/lib/generators/app/PobAppGenerator.js

+1
Original file line numberDiff line numberDiff line change
@@ -339,6 +339,7 @@ export default class PobAppGenerator extends Generator {
339339
case 'remix':
340340
this.composeWith('pob:app:remix', {});
341341
break;
342+
// no default
342343
}
343344

344345
if (platform !== 'win32') {

‎packages/pob/lib/generators/common/testing/CommonTestingGenerator.js

+2
Original file line numberDiff line numberDiff line change
@@ -263,6 +263,8 @@ export default class CommonTestingGenerator extends Generator {
263263
return '--loader=ts-node/esm --experimental-specifier-resolution=node';
264264
case 'swc':
265265
return '--import=@swc-node/register/esm';
266+
267+
// no default
266268
}
267269
})();
268270

‎packages/pob/lib/generators/monorepo/workspaces/MonorepoWorkspacesGenerator.js

+2
Original file line numberDiff line numberDiff line change
@@ -199,6 +199,8 @@ export default class MonorepoWorkspacesGenerator extends Generator {
199199
case 'yarn':
200200
// see CoreYarnGenerator
201201
break;
202+
default:
203+
throw new Error('Invalid packageManager');
202204
}
203205
}
204206
}

‎packages/pob/lib/generators/pob/PobBaseGenerator.js

+1
Original file line numberDiff line numberDiff line change
@@ -252,6 +252,7 @@ export default class PobBaseGenerator extends Generator {
252252
this.spawnCommandSync('npm', ['install']);
253253
break;
254254
case 'yarn':
255+
default:
255256
// see CoreYarnGenerator
256257
break;
257258
}

‎packages/pob/package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,9 @@
3939
"pob": {},
4040
"prettier": "@pob/root/prettier-config",
4141
"dependencies": {
42-
"@pob/eslint-config": "54.0.1",
43-
"@pob/eslint-config-typescript": "54.0.2",
44-
"@pob/eslint-config-typescript-react": "54.0.2",
42+
"@pob/eslint-config": "55.0.1",
43+
"@pob/eslint-config-typescript": "55.0.1",
44+
"@pob/eslint-config-typescript-react": "55.0.1",
4545
"@pob/sort-eslint-config": "5.2.1",
4646
"@pob/sort-object": "6.2.1",
4747
"@pob/sort-pkg": "7.0.0",

‎yarn.lock

+163-205
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)
Please sign in to comment.