Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next reviewflow comment template #136

Open
1 of 5 tasks
christophehurpeau opened this issue Dec 19, 2020 · 0 comments
Open
1 of 5 tasks

Next reviewflow comment template #136

christophehurpeau opened this issue Dec 19, 2020 · 0 comments

Comments

@christophehurpeau
Copy link
Owner

christophehurpeau commented Dec 19, 2020

Actual:

Options:

  • This PR is a feature branch
  • Add [skip ci] on merge commit
  • Auto merge when this PR is ready and has no failed statuses. (Also has a queue per repo to prevent multiple useless "Update branch" triggers)
  • Automatic branch delete after this PR is merged

Some ideas:

Steps

✔️ Step 1: ✏️ Write code
✔️ Step 2: ✅ CI passes
⬜ Step 3: 👌 Code Review
⬜ Step 4: 🎨 Design Review (optional)
⬜ Step 5: 🚦 Merging Pull Request

Note that step 1 would be draft PR

Labels (🔒 readonly)

👌 code/needs-review: present when the PR requires a review, either because it was not approved yet or because there is requested reviews.
☑️ 👌 code/approved: present when the PR is approved by a dev and no other requested reviews left.

Options

  • 🚦 automerge: Auto merge when this PR is ready and has no failed statuses. Reviewflow has a queue per repo to prevent multiple useless "Update branch" triggers.

Friendly error messages

Hey @christophehurpeau, this PR title does not follow commitlint conventional. Please update the PR's title !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant