Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document GitHub action outputs #298

Merged
merged 6 commits into from Mar 10, 2021

Conversation

mnquintana
Copy link
Contributor

Closes #293

This PR documents Chromatic's GitHub action's outputs, both in the Readme and in the action.yml manifest. It also adds a missing required field in the GitHub action schemarequired.

action.yml Show resolved Hide resolved
action.yml Show resolved Hide resolved
@ghengeveld
Copy link
Member

Thanks for contributing!

@mnquintana
Copy link
Contributor Author

👋🏽 Just checking in – anything I else I need to do to get this merge-ready?

@ghengeveld ghengeveld merged commit df14009 into chromaui:next Mar 10, 2021
@ghengeveld
Copy link
Member

All good, thanks a lot! 👍

@mnquintana mnquintana deleted the mnquintana/action-outputs branch March 10, 2021 21:25
@mnquintana
Copy link
Contributor Author

@ghengeveld Awesome, thanks so much for giving this a look! Would you also be able to publish a new version of the action soon?

@ghengeveld
Copy link
Member

Released in v5.7.0.

@mnquintana
Copy link
Contributor Author

Thanks a lot @ghengeveld! Would you also be able to publish a new release with the latest changes at https://github.com/chromaui/action? It looks like the last release was v1 back in September. Not a huge deal because it's still usable by pointing my GitHub Actions config at the latest commit hash, but it would be nice to express it in terms of a semver range again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document outputs and publish new version of action?
2 participants