Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve viewLayer and version from dependencies and support @web/dev-server-storybook #319

Merged
merged 7 commits into from Apr 23, 2021

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Apr 14, 2021

Fixes #317

This makes installing the Storybook viewlayer package to node_modules optional when using --storybook-build-dir. We won't need the Storybook CLI in that case, so we don't care whether it's installed.

I also added explicit support for @web/dev-server-storybook which required a bit of a refactor.

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@ghengeveld ghengeveld changed the title Retrieve viewLayer and version from dependencies Retrieve viewLayer and version from dependencies and support @web/dev-server-storybook Apr 22, 2021
@domyen
Copy link
Member

domyen commented Apr 23, 2021

Nice! This resolves #324 which has been reported by customers lately.

Co-authored-by: Dominic Nguyen <dom@hichroma.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support prebuilt Storybook package
4 participants