Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check existence and validity of package.json #334

Merged
merged 8 commits into from May 21, 2021
Merged

Check existence and validity of package.json #334

merged 8 commits into from May 21, 2021

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented May 2, 2021 •
edited

Fixes #290 and fixes #291

@ghengeveld ghengeveld changed the title Check existence of package.json Check existence and validity of package.json May 2, 2021
kylesuss
kylesuss approved these changes May 3, 2021
View reviewed changes
Copy link
Contributor

@kylesuss kylesuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bin/main.js Show resolved Hide resolved
coderkevin
coderkevin approved these changes May 18, 2021
View reviewed changes
Copy link
Contributor

@coderkevin coderkevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple optional comments.

bin/main.js Show resolved Hide resolved
bin/ui/messages/errors/noPackageJson.js Outdated Show resolved Hide resolved
@ghengeveld ghengeveld merged commit c681376 into next May 21, 2021
@ghengeveld ghengeveld deleted the check-package-json branch May 21, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderkevin coderkevin coderkevin approved these changes

@kylesuss kylesuss kylesuss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gracefully handle missing package.json Gracefully handle missing "scripts" block in package.json
3 participants
@ghengeveld @coderkevin @kylesuss