Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop spawnOptions, including preferLocal: true #350

Merged
merged 4 commits into from May 21, 2021
Merged

Drop spawnOptions, including preferLocal: true #350

merged 4 commits into from May 21, 2021

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented May 19, 2021 •
edited

This resolves the issue with node-sass.

Additionally, this logs nodeVersion as part of spawnParams for debugging.

tmeasday
tmeasday approved these changes May 20, 2021
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghengeveld ghengeveld merged commit 65cf52c into next May 21, 2021
@ghengeveld ghengeveld deleted the drop-preferLocal branch May 21, 2021 06:57
@ghengeveld
Copy link
Member Author

Shipped in chromatic@5.8.3. chromaui/action@v1 is automatically upgraded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ghengeveld @tmeasday