Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test.yml remove errant with: node-version #1352

Merged

Conversation

jtmoon79
Copy link
Contributor

@jtmoon79 jtmoon79 commented Nov 6, 2023

This with: node-version parameter is not specified by Swatinem/rust-cache@v2. Currently causing warnings for github Actions

Screenshot 2023-11-05 193129

https://github.com/chronotope/chrono/actions/runs/6757025993

@jtmoon79 jtmoon79 force-pushed the jtmoon79/test_yml_remove_errant_with branch from 7a1e319 to bf05126 Compare November 6, 2023 03:33
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #1352 (bf05126) into 0.4.x (02bdd1d) will increase coverage by 0.01%.
Report is 1 commits behind head on 0.4.x.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            0.4.x    #1352      +/-   ##
==========================================
+ Coverage   91.60%   91.61%   +0.01%     
==========================================
  Files          38       38              
  Lines       17430    17482      +52     
==========================================
+ Hits        15966    16016      +50     
- Misses       1464     1466       +2     

see 12 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@jtmoon79 jtmoon79 changed the title test.yml remove errant with test.yml remove errant with: node-version Nov 6, 2023
@jtmoon79
Copy link
Contributor Author

jtmoon79 commented Nov 6, 2023

There is currently a failing job test_msrv occurring prior to this PR. However, this PR only changed job alternative_targets. So this PR should be okay.

@jtmoon79 jtmoon79 marked this pull request as ready for review November 6, 2023 03:42
@djc djc merged commit fbd67ab into chronotope:0.4.x Nov 6, 2023
36 of 37 checks passed
@djc
Copy link
Contributor

djc commented Nov 6, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants