Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update windows-bindgen to 0.52 #1379

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Update windows-bindgen to 0.52 #1379

merged 1 commit into from
Jan 22, 2024

Conversation

djc
Copy link
Contributor

@djc djc commented Jan 22, 2024

Backport #1358 to 0.4.x.

@djc djc requested a review from pitdicker January 22, 2024 16:10
@djc djc mentioned this pull request Jan 22, 2024
1 task
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7757386) 91.69% compared to head (e929407) 91.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##            0.4.x    #1379   +/-   ##
=======================================
  Coverage   91.69%   91.69%           
=======================================
  Files          38       38           
  Lines       17608    17608           
=======================================
  Hits        16145    16145           
  Misses       1463     1463           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CITATION.cff Outdated
@@ -3,8 +3,8 @@ cff-version: 1.2.0
message: Please cite this crate using these information.

# Version information.
date-released: 2023-09-15
version: 0.4.31
date-released: 2024-01-22
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit duplicates #1378?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should "wash out" when it's merged.

However, this can also be fixed by rebasing this PR branch to the updated 0.4.x branch after PR #1378 is merged.

CITATION.cff Outdated
@@ -3,8 +3,8 @@ cff-version: 1.2.0
message: Please cite this crate using these information.

# Version information.
date-released: 2023-09-15
version: 0.4.31
date-released: 2024-01-22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should "wash out" when it's merged.

However, this can also be fixed by rebasing this PR branch to the updated 0.4.x branch after PR #1378 is merged.

@djc
Copy link
Contributor Author

djc commented Jan 22, 2024

I rebased it! Sorry for the confusion.

@djc djc merged commit bf70419 into 0.4.x Jan 22, 2024
37 checks passed
@djc djc deleted the win-0.52 branch January 22, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants