Use different method to ignore feature-dependent doctests #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1534 +/- ##
==========================================
+ Coverage 91.81% 91.82% +0.01%
==========================================
Files 40 40
Lines 18319 18345 +26
==========================================
+ Hits 16820 16846 +26
Misses 1499 1499 ☔ View full report in Codecov by Sentry. |
pitdicker
changed the title
djc
approved these changes
Mar 22, 2024
| @@ -279,6 +278,7 @@ impl<'a> StrftimeItems<'a> { | |||
| /// assert_eq!(fmtr.to_string(), "2023년 07월 11일"); | |||
| /// let fmtr = dt.format_with_items(StrftimeItems::new_with_locale("%x", Locale::ja_JP)); | |||
| /// assert_eq!(fmtr.to_string(), "2023年07月11日"); | |||
| /// # } | |||
There was a problem hiding this comment.
I don't see a matching opening brace...
pitdicker
commented
Mar 22, 2024
| #[cfg_attr(not(any(feature = "alloc", feature = "std")), doc = "```ignore")] | ||
| #[cfg_attr(any(feature = "alloc", feature = "std"), doc = "```rust")] | ||
| /// ``` | ||
| /// # #[cfg(feature = "alloc")] { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable an almost clean run with
cargo +nightly fmt -- --config format_code_in_doc_comments=true.It did not handle a combination of doc comments and
#[cfg_attr(feature = ..., doc = "...")]well.