Add `elapsed_years` to `Date` and `DateTime` #557

yozhgoor · 2021-04-27T13:51:47Z

Thanks for contributing to chrono!

Have you added yourself and the change to the changelog? (Don't worry
about adding the PR number)
If this pull request fixes a bug, does it add a test that verifies that
we can't reintroduce it?

Related to #416

I have make this PR for retrieve easily an age from a birthdate
The API is similar to std::time::Instant

quodlibetor · 2021-05-07T19:08:01Z

It seems like this would work better as a method on chrono::Duration?

yozhgoor · 2021-05-10T08:20:53Z

I need to use a date here, because years are not constant. A year is on average equals to 52.1428571 weeks so this will be really less accurate on chrono::Duration.

src/lib.rs

CHANGELOG.md

Co-authored-by: Cecile Tonglet <cecile.tonglet@cecton.com>

yozhgoor · 2021-06-13T17:21:28Z

Thanks @cecton for the spell checking :D

yozhgoor · 2021-06-13T17:29:40Z

I don't know what i do with this PR btw 🤔
It's not a problem if this don't fit with the API, at that point we can just close.
I just wanted to solve a problem I had and a few others as well (see #416 (comment) for example).
I don't have the level to try to calculate the elapsed years on Duration and this would also bring big changes to the API
This PR is the most accurate i can do for the moment 😄

Milo123459 · 2021-10-26T11:33:33Z

I think if you make it a method like Brandon said, this PR could get some work done on it and possibly get merged.

cecton · 2021-10-26T11:48:09Z

I think if you make it a method like Brandon said, this PR could get some work done on it and possibly get merged.

It can't be a method of duration because the exact date must be known.

cecton · 2021-10-26T11:48:54Z

I need to use a date here, because years are not constant. A year is on average equals to 52.1428571 weeks so this will be really less accurate on chrono::Duration.

☝️

Milo123459 · 2021-10-26T12:02:33Z

Woops didn't see

cecton · 2021-10-27T19:58:46Z

Thanks for the merge! ...though it doesn't seem the maintainer is interested in this API feature.

cecton · 2021-10-27T20:14:57Z

Ah cool then 🤗 That PR was staling for a while now. I understood it as a "no".

I'm afraid you failed the conflict resolution. I added a suggestion to fix it (it's not my PR, I don't think I can push on it)

CHANGELOG.md

Co-authored-by: Cecile Tonglet <cecile.tonglet@cecton.com>

Milo123459 · 2021-10-28T07:59:58Z

This PR sadly can't be merged until the tests are fixed, and it looks like some outdated methods are being used. Not sure though.

yozhgoor · 2021-10-28T11:10:37Z

Thanks @cecton and @Milo123459
I updated my fork for this PR and made some change. I have try to fix tests.

cecton · 2021-11-12T09:55:01Z

@Milo123459 this seems ready now 🚀

yozhgoor · 2021-11-12T10:33:34Z

I fix a conflict in CHANGELOG.md and i think i resolved the issues with Utc::now and Utc::today.
(I discovered the script to launch the CI locally too)

yozhgoor · 2021-12-08T17:15:50Z

@Milo123459 Can we give it another shot before new changes ?
Thanks

yozhgoor · 2022-01-10T11:37:57Z

So, this seems to be blocked again and I'm not sure why. What needs to be done to move forward?

This feature cannot be made on Duration because the exact date needs to be known to calculate the number of years exactly. Otherwise it would be an estimation of the numbers of years. My code here gives the exact number of years.

Do we want this feature or we don't want this feature? I would prefer to get a clear answer if possible.
Otherwise it feels like I'm being ignored without any reason provided.

Milo123459 · 2022-01-10T17:21:55Z

CHANGELOG.md

@@ -744,4 +745,3 @@ and replaced by 0.2.25 very shortly. Duh.)
 ## 0.1.0 (2014-11-20)

 The initial version that was available to `crates.io`.
-


Please remove this useless change

…ed-years

…etime.rs`

cecton · 2022-05-27T16:11:35Z

src/date.rs

@@ -275,6 +276,20 @@ impl<Tz: TimeZone> Date<Tz> {
    pub fn naive_local(&self) -> NaiveDate {
        self.date
    }
+
+    /// Retrieve the elapsed years from now to the given [`Date`].


consistency with other's function docs

Suggested change

/// Retrieve the elapsed years from now to the given [`Date`].

/// Retrieves the elapsed years from now to the given [`Date`].

djc · 2022-06-08T07:59:08Z

Unfortunately std::convert::TryFrom is not available in our MSRV target, so this needs some work.

djc · 2022-06-08T09:41:56Z

Sorry, can you rebase this again to pull in the fixes from #706?

yozhgoor added 16 commits April 21, 2021 19:08

Add elapsed_years() to Date

4d87d7f

Add elapsed_years() to DateTime

b3ee278

Add elapsed_years() to NaiveDateTime

a493f26

Oops

54274a2

Add elapsed_years() to NaiveDateTime

fb25a77

WIP

f059cb3

Remove elapsed_years from naive Date and DateTime

a5ce0b9

Add a consts module with WEEK_PER_YEAR

73eac80

Add better tests

351c1cf

Change variable name

767f87a

Clean up

6d569fb

Clean up

6ab485a

Update changelog and authors

5d1af60

Replace the Utc use by the timezone of the Date

cab008d

Clean up

f676c1f

Adapt changelog

4c52ec7

cecton reviewed May 25, 2021

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

src/lib.rs Outdated Show resolved Hide resolved

CHANGELOG.md Outdated Show resolved Hide resolved

yozhgoor and others added 3 commits June 13, 2021 19:20

Update src/lib.rs

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

5e3eba3

Co-authored-by: Cecile Tonglet <cecile.tonglet@cecton.com>

Update src/lib.rs

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

bd6a7a7

Co-authored-by: Cecile Tonglet <cecile.tonglet@cecton.com>

Update CHANGELOG.md

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

3006303

Co-authored-by: Cecile Tonglet <cecile.tonglet@cecton.com>

Merge branch 'main' into elapsed-years

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

520d83e

cecton reviewed Oct 27, 2021

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Milo123459 and others added 2 commits October 27, 2021 22:06

Update CHANGELOG.md

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

3fa7eaa

Co-authored-by: Cecile Tonglet <cecile.tonglet@cecton.com>

Update src/datetime.rs

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

a069d56

Co-authored-by: Cecile Tonglet <cecile.tonglet@cecton.com>

Update

a4a026a

yozhgoor added 2 commits November 12, 2021 11:27

Use the clock feature when using Utc::now and Utc::today

d82afcf

Merge branch 'main' into elapsed-years

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

b467923

Milo123459 reviewed Jan 10, 2022

View reviewed changes

yozhgoor added 5 commits January 10, 2022 20:48

New blank line at EOF

7816be1

Merge branch 'elapsed-years' of github.com:yozhgoor/chrono into elaps…

5a90aff

…ed-years

Merge branch 'main' into elapsed-years

ba17106

Move the code from datetime.rs to datetime/mod.rs and delete `dat…

81fabab

…etime.rs`

Clean up

d893578

cecton reviewed May 27, 2022

View reviewed changes

yozhgoor added 2 commits May 28, 2022 15:53

After review

83aab1a

Add crate:: to the use statement

07f1e43

yozhgoor marked this pull request as draft June 8, 2022 08:49

Replace TryFrom

22945a2

yozhgoor marked this pull request as ready for review June 8, 2022 09:22

Merge branch 'main' into elapsed-years

492c802

djc merged commit 1d33cbc into chronotope:main Jun 8, 2022

yozhgoor deleted the elapsed-years branch June 8, 2022 11:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `elapsed_years` to `Date` and `DateTime` #557

Add `elapsed_years` to `Date` and `DateTime` #557

yozhgoor commented Apr 27, 2021 •

edited

Loading

quodlibetor commented May 7, 2021

yozhgoor commented May 10, 2021

yozhgoor commented Jun 13, 2021

yozhgoor commented Jun 13, 2021 •

edited

Loading

Milo123459 commented Oct 26, 2021

cecton commented Oct 26, 2021

cecton commented Oct 26, 2021

Milo123459 commented Oct 26, 2021

cecton commented Oct 27, 2021

cecton commented Oct 27, 2021

Milo123459 commented Oct 28, 2021

yozhgoor commented Oct 28, 2021

cecton commented Nov 12, 2021

yozhgoor commented Nov 12, 2021

yozhgoor commented Dec 8, 2021

yozhgoor commented Jan 10, 2022

Milo123459 Jan 10, 2022

cecton May 27, 2022

djc commented Jun 8, 2022

djc commented Jun 8, 2022

		@@ -744,4 +745,3 @@ and replaced by 0.2.25 very shortly. Duh.)
		## 0.1.0 (2014-11-20)

		The initial version that was available to `crates.io`.

	/// Retrieve the elapsed years from now to the given [`Date`].
	/// Retrieves the elapsed years from now to the given [`Date`].

Add elapsed_years to Date and DateTime #557

Add elapsed_years to Date and DateTime #557

Conversation

yozhgoor commented Apr 27, 2021 • edited Loading

Thanks for contributing to chrono!

quodlibetor commented May 7, 2021

yozhgoor commented May 10, 2021

yozhgoor commented Jun 13, 2021

yozhgoor commented Jun 13, 2021 • edited Loading

Milo123459 commented Oct 26, 2021

cecton commented Oct 26, 2021

cecton commented Oct 26, 2021

Milo123459 commented Oct 26, 2021

cecton commented Oct 27, 2021

cecton commented Oct 27, 2021

Milo123459 commented Oct 28, 2021

yozhgoor commented Oct 28, 2021

cecton commented Nov 12, 2021

yozhgoor commented Nov 12, 2021

yozhgoor commented Dec 8, 2021

yozhgoor commented Jan 10, 2022

Milo123459 Jan 10, 2022

Choose a reason for hiding this comment

cecton May 27, 2022

Choose a reason for hiding this comment

djc commented Jun 8, 2022

djc commented Jun 8, 2022

Add `elapsed_years` to `Date` and `DateTime` #557

Add `elapsed_years` to `Date` and `DateTime` #557

yozhgoor commented Apr 27, 2021 •

edited

Loading

yozhgoor commented Jun 13, 2021 •

edited

Loading