use stub for anything not unix and not windows #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yu-re-ka
force-pushed
the
feature/fix-wasm
branch
from
85dbc65
to
91d1eba
Compare
2 tasks
|
Would you be able to rebase this on main? This looks like a good fix! |
Closed
yu-re-ka
force-pushed
the
feature/fix-wasm
branch
from
8729752
to
f687bab
Compare
yu-re-ka
force-pushed
the
feature/fix-wasm
branch
from
f687bab
to
9ac4e7b
Compare
Done |
|
Thanks for the quick reply, and sorry for the long wait! |
djc
approved these changes
Apr 9, 2022
|
The lint errors do not seem to be caused by my changes. |
|
That's right, they're clippy issues from the 1.60 upgrade. Unfortunately I don't have permission to merge in spite of failing CI. Can you fix them? Otherwise I'll get to it soon. |
|
I have pushed a commit that silences those warnings. If you would like a different fix you can force-push to my branch or tell me what you prefer. |
yu-re-ka
force-pushed
the
feature/fix-wasm
branch
from
1f2c563
to
51aa03e
Compare
|
Hopefully fixed lint for real... |
|
Great, thanks! |
Closed
|
Thank you! Much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to chrono!
Alternative to #568
Fixes #519
about adding the PR number)
we can't reintroduce it?