fixes #758 -- correctly document that %Y parses negative years #760
+27
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I wonder if we should more thoroughly document the edge cases here -- like how many characters this needs for NaiveDate::MIN. |
|
I think you dropped a word there :-) What should we do more thoroughly? |
|
Oops! "document" |
|
That's probably a good idea. Here I'm just trying to do the minimum to address the issue I ran into :-) |
djc
approved these changes
Aug 6, 2022
There was a problem hiding this comment.
LGTM. @esheppa what do you think?
I think it's better hear to keep the range for %Y consistent with the range we allow internally (as much as possible), such that we should allow negative years here -- and change the documentation -- vs following the documentation and clamping the year to some number (0000 or 0001, I suppose) to avoid negative years.
The documentation originates in 43ee68b. The implementation started allowing negative years in 0399ba1.
esheppa
approved these changes
Aug 9, 2022
There was a problem hiding this comment.
Looks good to me, and there are some tests for this in src/format/parse.rs so no need to add any more for this PR.
mtremer
pushed a commit
to ipfire/ipfire-2.x
that referenced
this pull request
Nov 11, 2022
- Updated from version 0.4.19 to 0.4.22 - Update of rootfile - Update of metadata patch as more windows related entries in Cargo.toml to be excluded - Changelog ## 0.4.22 * Allow wasmbindgen to be optional on `wasm32-unknown-unknown` target [(#771)](chronotope/chrono#771) * Fix compile error for `x86_64-fortanix-unknown-sgx` [(#767)](chronotope/chrono#767) * Update `iana-time-zone` version to 1.44 [(#773)](chronotope/chrono#773) ## 0.4.21 * Fall back to UTC timezone in cases where no timezone is found [(#756)](chronotope/chrono#756) * Correctly detect timezone on Android [(#756)](chronotope/chrono#756) * Improve documentation for strftime `%Y` specifier [(#760)](chronotope/chrono#760) ## 0.4.20 * Add more formatting documentation and examples. * Add support for microseconds timestamps serde serialization/deserialization (#304) * Fix `DurationRound` is not TZ aware (#495) * Implement `DurationRound` for `NaiveDateTime` * Implement `std::iter::Sum` for `Duration` * Add `DateTime::from_local()` to construct from given local date and time (#572) * Add a function that calculates the number of years elapsed between now and a given `Date` or `DateTime` (#557) * Correct build for wasm32-unknown-emscripten target (#568) * Change `Local::now()` and `Utc::now()` documentation from "current date" to "current date and time" (#647) * Fix `duration_round` panic on rounding by `Duration::zero()` (#658) * Add optional rkyv support. * Add support for microseconds timestamps serde serialization for `NaiveDateTime`. * Add support for optional timestamps serde serialization for `NaiveDateTime`. * Fix build for wasm32-unknown-emscripten (@yu-re-ka #593) * Make `ParseErrorKind` public and available through `ParseError::kind()` (#588) * Implement `DoubleEndedIterator` for `NaiveDateDaysIterator` and `NaiveDateWeeksIterator` * Fix panicking when parsing a `DateTime` (@botahamec) * Add support for getting week bounds based on a specific `NaiveDate` and a `Weekday` (#666) * Remove libc dependency from Cargo.toml. * Add the `and_local_timezone` method to `NaiveDateTime` * Fix the behavior of `Duration::abs()` for negative durations with non-zero nanos * Add compatibility with rfc2822 comments (#733) * Make `js-sys` and `wasm-bindgen` enabled by default when target is `wasm32-unknown-unknown` for ease of API discovery * Add the `Months` struct and associated `Add` and `Sub` impls Tested-by: Adolf Belka <adolf.belka@ipfire.org> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.