Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only issues using this project with rollup #71

Open
codeit-ninja opened this issue Aug 26, 2021 · 3 comments
Open

Only issues using this project with rollup #71

codeit-ninja opened this issue Aug 26, 2021 · 3 comments

Comments

@codeit-ninja
Copy link

I tried using this repo as this supports electron and vue 3 as a nice starter package.

Well, its hell itself with rollup. Litterly every package from npm breaks rollup. As example, try to use the firebase-admin SDK with this repo.

I dont know how to fix all these errors as I am not familair with rollup, but its tottaly broken. Project works fine aslong as you dont install thirt party dependecies.

@ci010
Copy link
Owner

ci010 commented Aug 27, 2021

Can you try to add firebase-admin this dependencies to external in package.json?
I guess this is caused by rollup cannot handle some circular deps in node modules.

I write a section about adding dependencies in online document... but it seems it's not intuitive...

Maybe I will figure out how to auto detect these kind of things automatically...

@ci010
Copy link
Owner

ci010 commented Aug 31, 2021

Some update...
Recently, I tried to use esbuild to bundle the project, and it seems work fine to me. (Blazing fast too)

One more issue need to resolve is importing the .node or native (carry binary inside) package.

If I solve those problem, I think this project will switch to esbuild to build main process.

@codeit-ninja
Copy link
Author

You are doing great work. I will retry this project tomorrow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants