Allow the Helm timeout to be set on uninstall #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maartje Eyskens <maartje.eyskens@isovalent.com>
asauber
approved these changes
Apr 27, 2023
| @@ -325,6 +325,8 @@ func newCmdUninstallWithHelm() *cobra.Command { | |||
| } | |||
|
|
|||
| addCommonUninstallFlags(cmd, ¶ms) | |||
|
|
|||
| cmd.Flags().DurationVar(¶ms.Timeout, "timeout", defaults.UninstallTimeout, "Maximum time to wait resources to be deleted") | |||
There was a problem hiding this comment.
Suggested change
| cmd.Flags().DurationVar(¶ms.Timeout, "timeout", defaults.UninstallTimeout, "Maximum time to wait resources to be deleted") | |
| cmd.Flags().DurationVar(¶ms.Timeout, "timeout", defaults.UninstallTimeout, "Maximum time to wait for resources to be deleted") |
| @@ -325,6 +325,8 @@ func newCmdUninstallWithHelm() *cobra.Command { | |||
| } | |||
|
|
|||
| addCommonUninstallFlags(cmd, ¶ms) | |||
|
|
|||
There was a problem hiding this comment.
nit: for consistency with the rest of the file, there shouldn't be a newline here
maintainer-s-little-helper
bot
added
ready-to-merge
michi-covalent
approved these changes
Apr 27, 2023
meyskens
added a commit
to meyskens/cilium-cli
that referenced
this pull request
Apr 28, 2023
This PR got merged with small nit comments. This adressed those in a seperate commit. Signed-off-by: Maartje Eyskens <maartje.eyskens@isovalent.com>
meyskens
added a commit
to meyskens/cilium-cli
that referenced
this pull request
Apr 28, 2023
The PR cilium#1550 got merged with small nit comments. This adressed those in a seperate commit. Signed-off-by: Maartje Eyskens <maartje.eyskens@isovalent.com>
tklauser
pushed a commit
that referenced
this pull request
Apr 28, 2023
The PR #1550 got merged with small nit comments. This adressed those in a seperate commit. Signed-off-by: Maartje Eyskens <maartje.eyskens@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running Helm in the CI setup i came against the limit that a cleanup of the tests namespace took longer than the Helm default of 5 minutes. However the timeout option was not exposed in out options thus could not be changed.
This PR exposes the
--timeouthelm option on uninstall when running in Helm mode.